Subject: Re: [PATCH net V2 1/2] virtio-net: don't respond to cpu hotplug notifier if we're not ready

From: "Michael S. Tsirkin" <[email-masked]>
Date: Thu, 17 Oct 2013 08:07:10 +0300

On Thu, Oct 17, 2013 at 09:57:41AM +1030, Rusty Russell wrote:
> Jason Wang <[email-masked]> writes:
> > We're trying to re-configure the affinity unconditionally in cpu hotplug
> > callback. This may lead the issue during resuming from s3/s4 since
> >
> > - virt queues haven't been allocated at that time.
> > - it's unnecessary since thaw method will re-configure the affinity.
> >
> > Fix this issue by checking the config_enable and do nothing is we're not ready.
> >
> > The bug were introduced by commit 8de4b2f3ae90c8fc0f17eeaab87d5a951b66ee17
> > (virtio-net: reset virtqueue affinity when doing cpu hotplug).
> >
> > Cc: Rusty Russell <[email-masked]>
> > Cc: Michael S. Tsirkin <[email-masked]>
> > Cc: Wanlong Gao <[email-masked]>
> > Acked-by: Michael S. Tsirkin <[email-masked]>
> > Reviewed-by: Wanlong Gao <[email-masked]>
> > Signed-off-by: Jason Wang <[email-masked]>
> > ---
> > The patch is need for 3.8 and above.
> 
> Please put 'CC: [email-masked] # 3.8+' in the commit.

Not if this is going in through the net tree.

> 
> (The specification of the stable line is poor, but that seems to be one
> common method).
> 
> Cheers,
> Rusty.