Subject: Re: [PATCH v2.44 2/5] ofp-actions: Add separate OpenFlow 1.3 action parser

From: Ben Pfaff <[email-masked]>
Date: Mon, 21 Oct 2013 13:19:45 -0700

On Thu, Oct 17, 2013 at 10:15:08AM +0900, Simon Horman wrote:
> From: Joe Stringer <[email-masked]>
> 
> This patch adds new ofpact_from_openflow13() and
> ofpacts_from_openflow13() functions parallel to the existing ofpact
> handling code. In the OpenFlow 1.3 version, push_mpls is handled
> differently, but all other actions are handled by the existing code.
> 
> In the case of push_mpls for OpenFlow 1.3 the new mpls_before_vlan field of
> struct ofpact_push_mpls is set to true.  This will be used by a subsequent
> patch to allow allow the correct VLAN+MPLS datapath behaviour to be
> determined at odp translation time.
> 
> enum ofpact_mpls_position contributed by Ben Pfaff.
> 
> Signed-off-by: Joe Stringer <[email-masked]>
> Signed-off-by: Simon Horman <[email-masked]>

I applied this commit to master, but I changed the commit message to:

>>From a7a2d006baae4152d338bd0bb4de1687084b1b07 Mon Sep 17 00:00:00 2001
From: Joe Stringer <[email-masked]>
Date: Thu, 17 Oct 2013 10:15:08 +0900
Subject: [PATCH] ofp-actions: Distinguish OF1.1/1.2 push_mpls from OF1.3+.

In OpenFlow 1.1 and 1.2, the push_mpls action pushes the MPLS label after
any existing VLAN tag.  In OpenFlow 1.3, it pushes the label before any
existing VLAN tag.  Until now, the action parser didn't distinguish these
cases.  This commit adds support.  Nothing yet actually changes the
behavior of push_mpls.

enum ofpact_mpls_position contributed by Ben Pfaff.

Signed-off-by: Joe Stringer <[email-masked]>
Signed-off-by: Simon Horman <[email-masked]>
Signed-off-by: Ben Pfaff <[email-masked]>