Subject: Re: [PATCH net] netpoll: fix rx_hook() interface by passing the skb

From: Antonio Quartulli <[email-masked]>
Date: Wed, 23 Oct 2013 14:44:01 +0200

On Wed, Oct 23, 2013 at 12:18:32PM +0100, David Laight wrote:
> > My idea is to use the following API:
> > 
> > rx_skb_hook(struct netpoll *np, int source, struct sk_buff *skb, int len);
> > 
> > Any suggestion or objection?
> 
> Don't you need to pass the offset of the udp data?

Yes, you are right. I just forgot it. Therefore we have:

rx_skb_hook(struct netpoll *np, int source, struct sk_buff *skb, int offset,
	    int len);

where offset is going to be = (udp_hdr + 1) - skb->data
and len = skb->len - offset

Regards,

-- 
Antonio Quartulli