Subject: Re: [PATCH net-next] net: add missing dev_put() in __netdev_adjacent_dev_insert

From: Veaceslav Falico <[email-masked]>
Date: Wed, 23 Oct 2013 15:36:52 +0200

On Wed, Oct 23, 2013 at 03:28:56PM +0200, Nikolay Aleksandrov wrote:
>I think that a dev_put() is needed in the error path to preserve the
>proper dev refcount.

True, forgot about it. Thanks for spotting this!

Acked-by: Veaceslav Falico <[email-masked]>

>
>CC: Veaceslav Falico <[email-masked]>
>Signed-off-by: Nikolay Aleksandrov <[email-masked]>
>---
> net/core/dev.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/net/core/dev.c b/net/core/dev.c
>index 0918aad..bdffd65 100644
>--- a/net/core/dev.c
>+++ b/net/core/dev.c
>@@ -4648,6 +4648,7 @@ remove_symlinks:
>
> free_adj:
> 	kfree(adj);
>+	dev_put(adj_dev);
>
> 	return ret;
> }
>-- 
>1.8.1.4
>