From: Hannes Frederic Sowa <hannes@stressinduktion•org>
To: Vladislav Yasevich <vyasevich@gmail•com>
Cc: Jiri Pirko <jiri@resnulli•us>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
David Miller <davem@davemloft•net>,
kuznet@ms2•inr.ac.ru, jmorris@namei•org, yoshfuji@linux-ipv6•org,
kaber@trash•net, thaller@redhat•com,
Stephen Hemminger <stephen@networkplumber•org>
Subject: Re: [patch net-next] ipv6: allow userspace to create address with IFLA_F_TEMPORARY flag
Date: Fri, 25 Oct 2013 22:12:53 +0200 [thread overview]
Message-ID: <20131025201253.GH15744@order.stressinduktion.org> (raw)
In-Reply-To: <CAGCdqXG6pOdaHNDsKnMGWKRs8Me7F8oyWVcgmtGP8ng2XRGfcQ@mail.gmail.com>
On Fri, Oct 25, 2013 at 06:05:40AM -0400, Vladislav Yasevich wrote:
> On Thu, Oct 24, 2013 at 12:59 PM, Jiri Pirko <jiri@resnulli•us> wrote:
> > Thu, Oct 24, 2013 at 04:02:53PM CEST, hannes@stressinduktion•org wrote:
> >>On Thu, Oct 24, 2013 at 03:45:55PM +0200, Jiri Pirko wrote:
> >>> This is needed in order to implement userspace address configuration,
> >>> namely ip6-privacy (rfc4941) in NetworkManager.
> >>>
> >>> Signed-off-by: Jiri Pirko <jiri@resnulli•us>
> >>> ---
> >>> net/ipv6/addrconf.c | 3 ++-
> >>> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> >>> index cd3fb30..962c7c9 100644
> >>> --- a/net/ipv6/addrconf.c
> >>> +++ b/net/ipv6/addrconf.c
> >>> @@ -3715,7 +3715,8 @@ inet6_rtm_newaddr(struct sk_buff *skb, struct nlmsghdr *nlh)
> >>> return -ENODEV;
> >>>
> >>> /* We ignore other flags so far. */
> >>> - ifa_flags = ifm->ifa_flags & (IFA_F_NODAD | IFA_F_HOMEADDRESS);
> >>> + ifa_flags = ifm->ifa_flags & (IFA_F_NODAD | IFA_F_HOMEADDRESS |
> >>> + IFA_F_TEMPORARY);
> >>>
> >>> ifa = ipv6_get_ifaddr(net, pfx, dev, 1);
> >>> if (ifa == NULL) {
> >>
> >>Hm, the kernel will pick up IFA_F_TEMPORARY marked addresses and do ipv6 address
> >>regeneration (depending on lifetimes). Is this intended?
> >
> > I think that that behaviour is valid. It is in compliance with valid lft and
> > preferred lft behaviour.
> >
>
> Actually, I don't think it would do the regeneration since ifpub
> pointer is not set.
>
> I appears that the temp address management would have to be done in
> userspace.
Sorry, yes this is correct. I should have looked at the source and not answer
just from memory.
Thanks,
Hannes
next prev parent reply other threads:[~2013-10-25 20:12 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 13:45 [patch net-next] ipv6: allow userspace to create address with IFLA_F_TEMPORARY flag Jiri Pirko
2013-10-24 13:48 ` [patch iproute2] allow to create temporary addresses Jiri Pirko
2013-10-24 14:02 ` [patch net-next] ipv6: allow userspace to create address with IFLA_F_TEMPORARY flag Hannes Frederic Sowa
2013-10-24 16:59 ` Jiri Pirko
2013-10-25 10:05 ` Vladislav Yasevich
2013-10-25 20:12 ` Hannes Frederic Sowa [this message]
2013-10-25 23:05 ` Vladislav Yasevich
2013-10-27 13:29 ` Jiri Pirko
2013-10-27 16:48 ` Hannes Frederic Sowa
2013-10-28 13:56 ` Vladislav Yasevich
2013-10-28 21:17 ` David Miller
2013-10-28 23:16 ` Dan Williams
2013-10-28 23:23 ` Dan Williams
2013-10-29 0:12 ` David Miller
2013-10-28 23:48 ` Hannes Frederic Sowa
2013-10-29 14:31 ` Dan Williams
2013-10-29 14:38 ` Hannes Frederic Sowa
2013-10-29 17:21 ` Dan Williams
2013-10-29 16:58 ` Vlad Yasevich
2013-10-29 17:15 ` Dan Williams
2013-10-29 0:08 ` David Miller
2013-10-29 0:13 ` Hannes Frederic Sowa
2013-10-29 0:46 ` David Miller
2013-10-28 23:31 ` Hannes Frederic Sowa
2013-10-29 0:43 ` David Miller
2013-10-29 9:37 ` David Laight
2013-10-29 12:40 ` Hannes Frederic Sowa
2013-10-29 13:09 ` Eric Dumazet
2013-10-29 13:11 ` Hannes Frederic Sowa
2013-10-29 19:58 ` David Miller
2013-11-01 21:28 ` Hannes Frederic Sowa
2013-11-05 17:02 ` Nicolas Dichtel
2013-11-05 17:12 ` David Laight
2013-11-05 21:11 ` Hannes Frederic Sowa
2013-11-06 9:23 ` David Laight
2013-11-06 12:03 ` Hannes Frederic Sowa
2013-11-05 20:57 ` Hannes Frederic Sowa
2013-11-06 8:11 ` Nicolas Dichtel
2013-11-09 0:54 ` [RFC PATCH net-next 1/2] ipv4: fix wildcard search with inet_confirm_addr() Nicolas Dichtel
2013-11-09 0:54 ` [RFC PATCH net-next 2/2] udp: add sk opt to allow sending pkt with src 0.0.0.0 Nicolas Dichtel
2013-11-09 14:46 ` Julian Anastasov
2013-11-12 8:59 ` Nicolas Dichtel
2013-11-11 5:18 ` David Miller
2013-11-14 13:05 ` Nicolas Dichtel
2013-11-14 19:57 ` David Miller
2013-11-18 9:15 ` Nicolas Dichtel
2013-11-14 14:31 ` Hannes Frederic Sowa
2013-11-14 20:00 ` David Miller
2013-10-29 19:44 ` [patch net-next] ipv6: allow userspace to create address with IFLA_F_TEMPORARY flag David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131025201253.GH15744@order.stressinduktion.org \
--to=hannes@stressinduktion$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=jiri@resnulli$(echo .)us \
--cc=jmorris@namei$(echo .)org \
--cc=kaber@trash$(echo .)net \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
--cc=thaller@redhat$(echo .)com \
--cc=vyasevich@gmail$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox