Subject: Re: [PATCH 3/3] vhost: fix the wrong log descriptions

From: "Michael S. Tsirkin" <[email-masked]>
Date: Mon, 18 Nov 2013 12:18:33 +0200

On Mon, Nov 18, 2013 at 11:19:23AM +0800, Zhi Yong Wu wrote:
> From: Zhi Yong Wu <[email-masked]>
> 
> Signed-off-by: Zhi Yong Wu <[email-masked]>

This one does not make sense to me.
Heads in avail ring are heads which according to Guest are available by
definition.

> ---
>  drivers/vhost/vhost.c  |    2 +-
>  drivers/vhost/vringh.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
> index 78987e4..568d20f 100644
> --- a/drivers/vhost/vhost.c
> +++ b/drivers/vhost/vhost.c
> @@ -1241,7 +1241,7 @@ int vhost_get_vq_desc(struct vhost_dev *dev, struct vhost_virtqueue *vq,
>  
>  	/* If their number is silly, that's an error. */
>  	if (unlikely(head >= vq->num)) {
> -		vq_err(vq, "Guest says index %u > %u is available",
> +		vq_err(vq, "Guest says index %u > %u is unavailable",
>  		       head, vq->num);
>  		return -EINVAL;
>  	}
> diff --git a/drivers/vhost/vringh.c b/drivers/vhost/vringh.c
> index 5174eba..86ef6c4 100644
> --- a/drivers/vhost/vringh.c
> +++ b/drivers/vhost/vringh.c
> @@ -57,7 +57,7 @@ static inline int __vringh_get_head(const struct vringh *vrh,
>  	}
>  
>  	if (head >= vrh->vring.num) {
> -		vringh_bad("Guest says index %u > %u is available",
> +		vringh_bad("Guest says index %u > %u is unavailable",
>  			   head, vrh->vring.num);
>  		return -EINVAL;
>  	}
> -- 
> 1.7.6.5