From: Thomas Graf <tgraf@suug•ch>
To: Nicolas Dichtel <nicolas.dichtel@6wind•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org
Subject: Re: [RFC PATCH v2] diag: warn about missing first netlink attribute
Date: Thu, 28 Nov 2013 22:09:09 +0000 [thread overview]
Message-ID: <20131128220909.GA4100@casper.infradead.org> (raw)
In-Reply-To: <1385659865-1926-1-git-send-email-nicolas.dichtel@6wind.com>
On 11/28/13 at 06:31pm, Nicolas Dichtel wrote:
> The first netlink attribute (value 0) must always be defined as none/unspec.
> This is correctly done in inet_diag.h, but other diag interfaces are wrong.
>
> Because we cannot change an existing API, I add a comment to point the mistake
> and avoid to propagate it in a new diag API in the future.
>
> CC: Thomas Graf <tgraf@suug•ch>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind•com>
> ---
>
> v2: just warn about the missing attribute
>
> If patch is approved, I will submit it when the net-next tree opens.
Acked-by: Thomas Graf <tgraf@suug•ch>
next prev parent reply other threads:[~2013-11-28 22:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 13:57 [PATCH net] diag: fix netlink API attributes Nicolas Dichtel
2013-11-28 16:38 ` Thomas Graf
2013-11-28 17:31 ` [RFC PATCH v2] diag: warn about missing first netlink attribute Nicolas Dichtel
2013-11-28 21:36 ` David Miller
2013-11-28 22:09 ` Thomas Graf [this message]
2013-11-28 23:16 ` David Miller
2013-11-28 17:37 ` [PATCH net] diag: fix netlink API attributes Nicolas Dichtel
2013-11-28 22:19 ` Thomas Graf
2013-11-29 8:28 ` Nicolas Dichtel
2013-11-29 8:42 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131128220909.GA4100@casper.infradead.org \
--to=tgraf@suug$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.dichtel@6wind$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox