From: Greg KH <gregkh@linuxfoundation•org>
To: Wei Liu <wei.liu2@citrix•com>
Cc: xen-devel@lists•xen.org, netdev@vger•kernel.org,
stable@vger•kernel.org, tomasz.wroblewski@citrix•com,
Ian Campbell <ian.campbell@citrix•com>,
Konrad Wilk <konrad.wilk@oracle•com>,
David Vrabel <david.vrabel@citrix•com>
Subject: Re: [[PATCH stable <3.12]] xen-netback: fix refcnt unbalance for 3.11 and earlier versions
Date: Mon, 2 Dec 2013 09:19:58 -0800 [thread overview]
Message-ID: <20131202171958.GA661@kroah.com> (raw)
In-Reply-To: <20131202120134.GA14293@zion.uk.xensource.com>
On Mon, Dec 02, 2013 at 12:01:34PM +0000, Wei Liu wrote:
> On Sat, Nov 30, 2013 at 08:48:35PM -0800, Greg KH wrote:
> > On Thu, Nov 28, 2013 at 12:48:09PM +0000, Wei Liu wrote:
> > > With the introduction of "xen-netback: Don't destroy the netdev until
> > > the vif is shut down" (upstream commit id 279f438e36), vif disconnect
> > > and free are separated. However in the backported verion reference
> > > counting code was not correctly modified, and the reset of vif->tx_irq
> > > was lost. If frontend goes through vif life cycle more than once the
> > > reference counting is skewed.
> > >
> > > This patch adds back the missing tx_irq reset line. It also moves
> > > several lines of the reference counting code to vif_free, so the moved
> > > code corresponds to the counterpart in vif_alloc, thus the reference
> > > counting is balanced.
> > >
> > > 3.12 and onward versions are not affected by this bug, because reference
> > > counting code was removed due to the introduction of 1:1 model.
> > >
> > > This pacth should be backported to all stable verions which are lower
> > > than 3.12 and have 279f438e36.
> >
> > What stable versions are those? 279f438e36 showed up in 3.12-rc2, and
> > was not marked for stable inclusion, so what kernel would end up needing
> > this patch?
> >
>
> Greg,
>
> 279f438e36 was backported to at least stable branches
>
> 3.11.y: <13826815042174@kroah•org> commit id f495ddc46
> 3.10.y: <13828112161592@kroah•com> commit id a4626bf64
>
> So at least those two need this patch.
>
> And I remeber 3.8.y.z extended stable branch maintained by Kamal also
> has the said commit.
>
> > confused,
> >
>
> Sorry, I should've stated cleared all versions.
>
> BTW the above patch applies to 3.11.y. I can provide backports to 3.10.y
> as well, if necessary.
As 3.11.y is now dead, there's not much I can do with that one, but I
could use a backport for 3.10.y, as this patch does not apply there,
thanks.
greg k-h
next prev parent reply other threads:[~2013-12-02 17:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 12:48 [[PATCH stable <3.12]] xen-netback: fix refcnt unbalance for 3.11 and earlier versions Wei Liu
2013-11-28 13:08 ` Ian Campbell
2013-11-28 13:13 ` Wei Liu
2013-11-30 21:19 ` David Miller
2013-12-01 4:48 ` Greg KH
2013-12-02 12:01 ` Wei Liu
2013-12-02 17:19 ` Greg KH [this message]
2013-12-02 17:49 ` Wei Liu
2013-12-02 17:58 ` Greg KH
2013-12-02 17:59 ` Patch "xen-netback: fix refcnt unbalance for 3.10" has been added to the 3.10-stable tree gregkh
2013-12-20 10:02 ` [[PATCH stable <3.12]] xen-netback: fix refcnt unbalance for 3.11 and earlier versions Luis Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131202171958.GA661@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=david.vrabel@citrix$(echo .)com \
--cc=ian.campbell@citrix$(echo .)com \
--cc=konrad.wilk@oracle$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stable@vger$(echo .)kernel.org \
--cc=tomasz.wroblewski@citrix$(echo .)com \
--cc=wei.liu2@citrix$(echo .)com \
--cc=xen-devel@lists$(echo .)xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox