From: Greg KH <gregkh@linuxfoundation•org>
To: Sarah Sharp <sarah.a.sharp@linux•intel.com>
Cc: David Miller <davem@davemloft•net>,
David Laight <David.Laight@ACULAB•COM>,
mlord@pobox•com, linux-usb@vger•kernel.org,
netdev@vger•kernel.org
Subject: Re: [GIT PULL] xhci: Regression fix for 3.13.
Date: Fri, 6 Dec 2013 10:26:36 -0800 [thread overview]
Message-ID: <20131206182636.GA30381@kroah.com> (raw)
In-Reply-To: <20131206181947.GB14254@xanatos>
On Fri, Dec 06, 2013 at 10:19:47AM -0800, Sarah Sharp wrote:
> On Fri, Dec 06, 2013 at 05:46:40PM -0000, David Laight wrote:
> > > From: David Miller [mailto:davem@davemloft•net]
> > > > From: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
> > > > Date: Fri, 6 Dec 2013 09:29:47 -0800
> > >
> > > > On Fri, Dec 06, 2013 at 09:03:25AM -0800, Sarah Sharp wrote:
> > > >> On Fri, Dec 06, 2013 at 12:55:23AM -0500, Mark Lord wrote:
> > > >> > On 13-12-02 04:42 PM, Greg Kroah-Hartman wrote:
> > > >> > > On Mon, Dec 02, 2013 at 12:49:08PM -0800, Sarah Sharp wrote:
> > > >> > >> The following changes since commit c24cb6c8b501ebdf1aacec7960110a9741a45ced:
> > > >> > >>
> > > >> > >> Merge tag 'fixes-for-v3.13-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb
> > > into usb-linus (2013-11-27 09:49:03 -0800)
> > > >> > >>
> > > >> > >> are available in the git repository at:
> > > >> > >>
> > > >> > >>
> > > >> > >> git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git tags/for-usb-linus-2013-12-02
> > > >> > >
> > > >> > > Pulled and pushed out, thanks.
> > > >> >
> > > >> > Did this commit make it into linux-3.12.3 ?
> > > >> >
> > > >> > I ask, because the NIC still locks up with that kernel,
> > > >> > and even with the patch I had been using from David Laight.
> > > >> >
> > > >> > Reverting the change that originally broke it still works though.
> > > >> > Could we please get this reverted until such time as a reworked
> > > >> > patch can be prepared for it?
> > > >>
> > > >> Greg, can you please revert David's patch (commit 35773dac5f86 from your
> > > >> usb-linus branch)?
> > > >
> > > > Now reverted.
> > >
> > > Please NO!
> > >
> > > Merge the XHCI change, the change you have reverted actually fixes
> > > things for some people and the XHCI change gets rid of the stated
> > > regression.
> >
> > I thought Mark had said that my patch fixed things for him with the
> > earlier kernel. It certainly makes a massive difference on my system.
> > And I ran with enough diagnostics to work out when the tx side
> > stopped. The last packet for which an ack was received was the one
> > before the one that straddled the ring end.
> >
> > If you want to change the ax179 driver you need to stop it using
> > SG and segmentation offload.
> > The patch that mark is talking about isn't really the one that makes a
> > difference.
> > I think it just forces the skb be linearised at that point. Which mostly
> > means that there won't be any fragments.
>
> Ok, so David verifies the xHCI driver does have an issue, and the patch
> does fix the issue as stated. Fine, let's merge that patch and see if
> it helps. Greg, can you fix this? Sorry for the churn.
Yes, I've pushed it to Linus now, not including the revert.
greg k-h
prev parent reply other threads:[~2013-12-06 18:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 20:49 [GIT PULL] xhci: Regression fix for 3.13 Sarah Sharp
2013-12-02 20:49 ` [PATCH 1/1] usb: xhci: Link TRB must not occur within a USB payload burst Sarah Sharp
2013-12-02 21:42 ` [GIT PULL] xhci: Regression fix for 3.13 Greg Kroah-Hartman
[not found] ` <20131202214205.GA26175-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2013-12-06 5:55 ` Mark Lord
2013-12-06 15:25 ` Greg Kroah-Hartman
2013-12-06 15:28 ` David Laight
[not found] ` <20131206152512.GA23212-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2013-12-07 4:10 ` Mark Lord
2013-12-16 21:21 ` Sarah Sharp
2013-12-17 3:33 ` Mark Lord
2013-12-06 17:03 ` Sarah Sharp
2013-12-06 17:19 ` David Laight
2013-12-06 17:29 ` David Miller
2013-12-06 17:29 ` Greg Kroah-Hartman
2013-12-06 17:32 ` David Miller
2013-12-06 17:46 ` David Laight
2013-12-06 18:19 ` Sarah Sharp
2013-12-06 18:26 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206182636.GA30381@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=David.Laight@ACULAB$(echo .)COM \
--cc=davem@davemloft$(echo .)net \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=mlord@pobox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sarah.a.sharp@linux$(echo .)intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox