From: Steffen Klassert <steffen.klassert@secunet•com>
To: Fan Du <fan.du@windriver•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org
Subject: Re: [PATCH net-next] xfrm: Namespacify xfrm_policy_sk_bundles
Date: Mon, 16 Dec 2013 13:23:25 +0100 [thread overview]
Message-ID: <20131216122325.GI31491@secunet.com> (raw)
In-Reply-To: <1387189568-31769-1-git-send-email-fan.du@windriver.com>
On Mon, Dec 16, 2013 at 06:26:08PM +0800, Fan Du wrote:
>
> And also since xfrm_policy_sk_bundles is only used in xfrm_lookup and
> __xfrm_garbage_collect, both in process context, no reason we should turn
> BH off.
Are you sure about that?
__xfrm_garbage_collect() is called via dst_alloc() which can be called
from softirq and process context.
> In addition we can use xchg to avoid the spinlock, inspired by
> discussion in: http://marc.info/?l=linux-netdev&m=138713363113003&w=2
>
> Signed-off-by: Fan Du <fan.du@windriver•com>
> ---
> Please note this patch is based on commit 283bc9f35bbbcb0e9ab4e6d2427da7f9f710d52d
> ("xfrm: Namespacify xfrm state/policy locks"), which is still in ipsec-next tree.
>
You could use
Subject: [PATCH ipsec-next] xfrm: Namespacify xfrm_policy_sk_bundles
then everybody should know on which tree it is based.
next prev parent reply other threads:[~2013-12-16 12:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 10:26 [PATCH net-next] xfrm: Namespacify xfrm_policy_sk_bundles Fan Du
2013-12-16 12:23 ` Steffen Klassert [this message]
2013-12-17 1:45 ` Fan Du
2013-12-17 11:39 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131216122325.GI31491@secunet.com \
--to=steffen.klassert@secunet$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=fan.du@windriver$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox