Subject: Re: [PATCH net-next 1/3] netconf: rename PROXY_ARP to NEIGH_PROXY

From: Stephen Hemminger <[email-masked]>
Date: Wed, 18 Dec 2013 10:06:06 -0800

On Wed, 18 Dec 2013 12:06:45 -0500
Jamal Hadi Salim <[email-masked]> wrote:

> On 12/18/13 01:35, Stephen Hemminger wrote:
> > Use same field for both IPv4 (proxy_arp) and IPv6 (proxy_ndp)
> > so fix it before API is set to be a common name
> >
> > Signed-off-by: Stephen Hemminger <[email-masked]>
> >
> > ---
> >   include/uapi/linux/netconf.h |    2 +-
> >   net/ipv4/devinet.c           |   10 +++++-----
> >   2 files changed, 6 insertions(+), 6 deletions(-)
> >
> > --- a/include/uapi/linux/netconf.h	2013-12-17 22:30:00.000000000 -0800
> > +++ b/include/uapi/linux/netconf.h	2013-12-17 22:31:07.973419694 -0800
> > @@ -14,7 +14,7 @@ enum {
> >   	NETCONFA_FORWARDING,
> >   	NETCONFA_RP_FILTER,
> >   	NETCONFA_MC_FORWARDING,
> > -	NETCONFA_PROXY_ARP,
> > +	NETCONFA_PROXY_NEIGH,
> >   	__NETCONFA_MAX
> >   };
> 
> Can you do this? ;-> Why not #define NETCONFA_PROXY_NEIGH to be 
> NETCONFA_PROXY_ARP
> 
> cheers,
> jamal
> 

The patch is against un-released net-next and only changes something
that was just added.