From: Greg KH <gregkh@linuxfoundation•org>
To: Larry Finger <Larry.Finger@lwfinger•net>
Cc: devel@driverdev•osuosl.org, netdev@vger•kernel.org
Subject: Re: [PATCH 01/11] staging: r8188eu: Remove pointless thread_exit macro
Date: Fri, 20 Dec 2013 12:34:56 -0800 [thread overview]
Message-ID: <20131220203456.GA14617@kroah.com> (raw)
In-Reply-To: <52B4A8EF.1010109@lwfinger.net>
On Fri, Dec 20, 2013 at 02:30:39PM -0600, Larry Finger wrote:
> On 12/20/2013 01:18 PM, Greg KH wrote:
> > On Fri, Dec 20, 2013 at 11:22:35AM -0600, Larry Finger wrote:
> >> On 12/20/2013 10:58 AM, Greg KH wrote:
> >>> With this series applied, I get a ton of "unused variable" warnings, can
> >>> you please fix them up now too?
> >>
> >> Strange, but I don't get any. My compiler is gcc (SUSE Linux) 4.8.1 20130909
> >> [gcc-4_8-branch revision 202388] from openSUSE 13.1. What version are you using?
> >>
> >
> > I'm using an older version:
> > $ gcc --version
> > gcc (Gentoo 4.7.3-r1 p1.3, pie-0.5.5) 4.7.3
> >
> > Odd. I'll move up to 4.8 and try that...
> >
> > Nope, same problem, here's one example line:
> > drivers/staging/rtl8188eu/core/rtw_ap.c: In function ‘rtw_ap_inform_ch_switch’:
> > drivers/staging/rtl8188eu/core/rtw_ap.c:1773:16: warning: unused variable ‘irqL’ [-Wunused-variable]
> > unsigned long irqL;
> >
> > This is x86-64, could that be an issue?
>
> Mine is x86_64 as well.
>
> I see the extra lines for "irqL" that gcc 4.7 finds but 4.8 misses. You should
> probably stay at 4.7 to catch the things that 4.8 misses.
Nah, I just switched to 4.8 and rebuilt all of the different kernel
trees on this box with it, so I'll stay there for now.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject•org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2013-12-20 20:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 4:38 [PATCH 00/11] staging: r8188eu: Clean up a number of pointless wrappers Larry Finger
2013-12-20 4:38 ` [PATCH 01/11] staging: r8188eu: Remove pointless thread_exit macro Larry Finger
2013-12-20 16:58 ` Greg KH
2013-12-20 17:22 ` Larry Finger
2013-12-20 19:18 ` Greg KH
2013-12-20 20:30 ` Larry Finger
2013-12-20 20:34 ` Greg KH [this message]
2013-12-20 20:43 ` Larry Finger
2013-12-20 4:38 ` [PATCH 02/11] staging: r8188eu: Remove wrapper around spin_lock_bh Larry Finger
2013-12-20 7:14 ` Dan Carpenter
2013-12-20 16:36 ` Larry Finger
2013-12-20 16:57 ` Greg KH
2013-12-20 4:38 ` [PATCH 03/11] staging: r8188eu: Remove wrapper around spin_unlock_bh Larry Finger
2013-12-20 4:38 ` [PATCH 04/11] staging: r8188eu: Remove wrappers for spin_lock_irqsave Larry Finger
2013-12-20 4:38 ` [PATCH 05/11] staging: r8188eu: Remove wrappers around spin_unlock_irqrestore Larry Finger
2013-12-20 4:38 ` [PATCH 06/11] staging: r8188eu: Remove wrapper around spin_lock_init Larry Finger
2013-12-20 4:38 ` [PATCH 07/11] staging: r8188eu: Remove calls to _rtw_spinlock_free Larry Finger
2013-12-20 4:38 ` [PATCH 08/11] staging: r8188eu: Replace rtw_get_current_time() with jiffies Larry Finger
2013-12-20 4:38 ` [PATCH 09/11] staging: r8188eu: Replace wrappers ODM_sleep_ms() and rtw_msleep_os() with a simple msleep Larry Finger
2013-12-20 4:38 ` [PATCH 10/11] staging: r8188eu: Replace wrappers ODM_delay_ms() and rtw_mdelay_os() with a simple mdelay Larry Finger
2013-12-20 4:38 ` [PATCH 11/11] staging: r8188eu: Replace wrappers ODM_StallExecution, ODM_delay_us, and rtw_udelay_os Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131220203456.GA14617@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=Larry.Finger@lwfinger$(echo .)net \
--cc=devel@driverdev$(echo .)osuosl.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox