From: Eli Cohen <eli@dev•mellanox.co.il>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
Cc: Stephen Hemminger <shemming@brocade•com>,
Eli Cohen <eli@mellanox•com>, David Miller <davem@davemloft•net>,
netdev@vger•kernel.org
Subject: Re: [PATCH net-next] mlx5: remove dead code
Date: Tue, 31 Dec 2013 18:03:07 +0200 [thread overview]
Message-ID: <20131231160306.GA20236@mtldesk30> (raw)
In-Reply-To: <52C15F5A.80601@cogentembedded.com>
Thanks. I noticed that and will address in the next patch set I plan
to send.
On Mon, Dec 30, 2013 at 03:56:10PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 30-12-2013 1:51, Stephen Hemminger wrote:
>
> >There are 3 functions in the mlx5 driver which are used and should be
>
> s/used/unused/, I think.
>
> >deleted. Upstream is not the repository to hold old dead code, or code
> >which is used by outside drivers, or code intended for future undetermined
> >features.
>
> >Signed-off-by: Stephen Hemminger <stephen@networkplumber•org>
>
> WBR, Sergei
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-12-31 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-29 21:51 [PATCH net-next] mlx5: remove dead code Stephen Hemminger
2013-12-30 11:56 ` Sergei Shtylyov
2013-12-31 16:03 ` Eli Cohen [this message]
2013-12-31 18:45 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131231160306.GA20236@mtldesk30 \
--to=eli@dev$(echo .)mellanox.co.il \
--cc=davem@davemloft$(echo .)net \
--cc=eli@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=shemming@brocade$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox