From: Stephen Hemminger <stephen@networkplumber•org>
To: netdev@vger•kernel.org
Subject: Fw: [Bug 68011] New: spin_unlock is missed in function (netpoll_send_skb_on_dev) in file (linux-3.12/net/core/netpoll.c)
Date: Wed, 1 Jan 2014 21:52:31 -0800 [thread overview]
Message-ID: <20140101215231.50ea361e@nehalam.linuxnetplumber.net> (raw)
Begin forwarded message:
Date: Wed, 1 Jan 2014 11:52:20 -0800
From: "bugzilla-daemon@bugzilla•kernel.org" <bugzilla-daemon@bugzilla•kernel.org>
To: "stephen@networkplumber•org" <stephen@networkplumber•org>
Subject: [Bug 68011] New: spin_unlock is missed in function (netpoll_send_skb_on_dev) in file (linux-3.12/net/core/netpoll.c)
https://bugzilla.kernel.org/show_bug.cgi?id=68011
Bug ID: 68011
Summary: spin_unlock is missed in function
(netpoll_send_skb_on_dev) in file
(linux-3.12/net/core/netpoll.c)
Product: Networking
Version: 2.5
Kernel Version: 3.12
Hardware: x86-64
OS: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: Other
Assignee: shemminger@linux-foundation•org
Reporter: atamrawi@iastate•edu
Regression: No
In function (netpoll_send_skb_on_dev) in file (linux-3.12/net/core/netpoll.c):
The structure (txq->_xmit_lock) gets successfully locked at line (383) by
(__netif_tx_trylock(txq)) and unlocked by (__netif_tx_unlock(txq)) at line
(398).
The problem occurs when the loop breaks at line (390) and the structure
(txq->_xmit_lock) still locked. In that case, the structure (txq->_xmit_lock)
never gets unlocked.
A possible solution is to call (__netif_tx_unlock(txq)) before the break at
line (390)
--
You are receiving this mail because:
You are the assignee for the bug.
next reply other threads:[~2014-01-02 5:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-02 5:52 Stephen Hemminger [this message]
2014-01-03 0:51 ` [Bug 68011] New: spin_unlock is missed in function (netpoll_send_skb_on_dev) in file (linux-3.12/net/core/netpoll.c) David Miller
2014-01-03 4:50 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140101215231.50ea361e@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox