From: Florian Westphal <fw@strlen•de>
To: David Miller <davem@davemloft•net>
Cc: fw@strlen•de, netdev@vger•kernel.org
Subject: Re: [PATCH] macvlan: fix oops with vlan-on-top and HW_VLAN_CTAG_TX lowerdev
Date: Fri, 3 Jan 2014 12:39:04 +0100 [thread overview]
Message-ID: <20140103113904.GB28854@breakpoint.cc> (raw)
In-Reply-To: <20131231.162448.1656983197554902144.davem@davemloft.net>
David Miller <davem@davemloft•net> wrote:
> vlan: Fix header ops passthru when doing TX VLAN offload.
>
> When the vlan code detects that the real device can do TX VLAN offloads
> in hardware, it tries to arrange for the real device's header_ops to
> be invoked directly.
Sorry for the late reply.
> +static inline int dev_rebuild_header(struct sk_buff *skb)
> +{
> + const struct net_device *dev = skb->dev;
> +
> + if (!dev->header_ops || !dev->header_ops->rebuild)
> + return 0;
> + return dev->header_ops->rebuild(skb);
> +}
> +
[..]
> +static const struct header_ops vlan_passthru_header_ops = {
> + .create = vlan_passthru_hard_header,
> + .rebuild = dev_rebuild_header,
Doesn't that result in infinite recursion when invoking
dev_rebuild_header() on skb whose dev->header_ops is
vlan_passthru_header_ops?
next prev parent reply other threads:[~2014-01-03 11:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-28 13:38 [PATCH] macvlan: fix oops with vlan-on-top and HW_VLAN_CTAG_TX lowerdev Florian Westphal
2013-12-29 22:01 ` David Miller
2013-12-30 10:27 ` Florian Westphal
2013-12-31 21:24 ` David Miller
2014-01-03 11:39 ` Florian Westphal [this message]
2014-01-03 20:33 ` David Miller
2014-01-04 13:51 ` Florian Westphal
2014-01-05 1:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140103113904.GB28854@breakpoint.cc \
--to=fw@strlen$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox