public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Sabrina Dubroca <sd@queasysnail•net>
To: Stephen Hemminger <stephen@networkplumber•org>
Cc: davem@davemloft•net, bhutchings@solarflare•com,
	johannes@sipsolutions•net, netdev@vger•kernel.org
Subject: Re: [PATCH v2 3/5] alx: add stats update function
Date: Sun, 5 Jan 2014 00:16:32 +0100	[thread overview]
Message-ID: <20140104231632.GA32402@kria> (raw)
In-Reply-To: <20140104141608.5d882082@nehalam.linuxnetplumber.net>

[2014-01-04] Stephen Hemminger wrote:
> On Sat,  4 Jan 2014 17:47:09 +0100
> Sabrina Dubroca <sd@queasysnail•net> wrote:
> 
> >  }
> > +
> > +void __alx_update_hw_stats(struct alx_hw *hw)
> 
> Minor NIT:
> Why __ prefix? that is usually reserved for functions only
> called from one file (or when wrapping an existing API)

In the original code, that's the name it had, so I just kept it. There
were two additional wrappers, but in Johannes's rewrite of the driver,
they became unnecessary.
I'll rename it to alx_update_hw_stats in v3.


I didn't know about that convention. I can't find a reference in
Documentation/CodingStyle, or from a quick look at a grep in the rest
of the files there: maybe it should be added to the documentation?


Thanks,

-- 
Sabrina

next prev parent reply	other threads:[~2014-01-04 23:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-04 16:47 [PATCH v2 0/5] alx: add statistics Sabrina Dubroca
2014-01-04 16:47 ` [PATCH v2 1/5] alx: add a hardware stats structure Sabrina Dubroca
2014-01-04 16:47 ` [PATCH v2 2/5] alx: add constants for the stats fields Sabrina Dubroca
2014-01-04 16:47 ` [PATCH v2 3/5] alx: add stats update function Sabrina Dubroca
2014-01-04 22:16   ` Stephen Hemminger
2014-01-04 23:16     ` Sabrina Dubroca [this message]
2014-01-04 16:47 ` [PATCH v2 4/5] alx: add alx_get_stats64 operation Sabrina Dubroca
2014-01-04 16:47 ` [PATCH v2 5/5] alx: add stats to ethtool Sabrina Dubroca
2014-01-06  9:03   ` Johannes Berg
2014-01-06 10:57     ` Sabrina Dubroca
2014-01-06 14:11       ` Johannes Berg
2014-01-06 14:56         ` Sabrina Dubroca
2014-01-06 15:16           ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140104231632.GA32402@kria \
    --to=sd@queasysnail$(echo .)net \
    --cc=bhutchings@solarflare$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=johannes@sipsolutions$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=stephen@networkplumber$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox