Subject: Re: [PATCH 0/6] phylib: cleanups

From: Richard Cochran <[email-masked]>
Date: Sun, 5 Jan 2014 09:31:10 +0100

On Sat, Jan 04, 2014 at 09:53:59PM +0300, Sergei Shtylyov wrote:
> 
> >    Because get_maintainer.pl doesn't suggest it and because Andy Fleming
> >seems no longer interested in maintaining his code written back in 2004.

It never hurts to ask.

Your patches are saying, "Andy, your code has poor style." I don't
agree, especially about #3. Also, maybe the deleted callback will
useful one day. After all, there are not that many phylib
drivers. Perhaps future MAC drivers will need this.
 
>    Besides, I don't have his current email address (the source code
> doesn't provide any).

Here, let me find that for you.

Thanks,
Richard
---
git log --author="Andy Fleming"

commit 39fd40274d1f3a52152ae6fc22f428d93f1a8363
Author: Andy Fleming <[email-masked]>
Date:   Mon Aug 5 14:58:35 2013 -0500

    powerpc: Convert platforms to smp_generic_cpu_bootable
    
    T4, Cell, powernv, and pseries had the same implementation, so switch
    them to use a generic version. A2 apparently had a version, but
    removed it at some point, so we remove the declaration, too.
    
    Signed-off-by: Andy Fleming <[email-masked]>
    Signed-off-by: Benjamin Herrenschmidt <[email-masked]>

commit 3cd852502316d42e3e75859e92d9f0a952bb55a2
Author: Andy Fleming <[email-masked]>
Date:   Mon Aug 5 14:58:34 2013 -0500

    powerpc: Add smp_generic_cpu_bootable
    
    Cell and PSeries both implemented their own versions of a
    cpu_bootable smp_op which do the same thing (well, the PSeries
    one has support for more than 2 threads). Copy the PSeries one
    to generic code, and rename it smp_generic_cpu_bootable.
    
    Signed-off-by: Andy Fleming <[email-masked]>
    Signed-off-by: Benjamin Herrenschmidt <[email-masked]>