From: Stephen Hemminger <stephen@networkplumber•org>
To: David Miller <davem@davemloft•net>
Cc: christophe.gouault@6wind•com, netdev@vger•kernel.org,
amwang@redhat•com, saurabh@vyatta•com
Subject: Re: [PATCH net] vti: get rid of nf mark rule in prerouting
Date: Mon, 6 Jan 2014 20:59:32 -0800 [thread overview]
Message-ID: <20140106205932.29553fd2@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <20131011.145304.305063991853045981.davem@davemloft.net>
On Fri, 11 Oct 2013 14:53:04 -0400 (EDT)
David Miller <davem@davemloft•net> wrote:
> From: Christophe Gouault <christophe.gouault@6wind•com>
> Date: Tue, 8 Oct 2013 17:21:22 +0200
>
> > This patch fixes and improves the use of vti interfaces (while
> > lightly changing the way of configuring them).
> ...
> > Signed-off-by: Christophe Gouault <christophe.gouault@6wind•com>
> > ---
> > This is is both a fix and enhancement patch. However, there are 2 ways
> > of fixing the inbound processing bug:
> > - either keep the current configuration model (ikey + netfilter rule)
> > and change the tunnel lookup method. This patch would then be reverted
> > by the enhancement (this sounds counterproductive).
> > - or directly change the configuration model (okey, no netfilter rule) and keep
> > the current tunnel lookup method.
>
> Ok, applied and queued up for -stable, thanks.
I hate to reply to old threads, but this keeps context.
We have discovered a problem with this patch, it breaks the earlier use of VTI
because it loses the mark applied through iptables. It was not a "light change"
to the way to configure them and should have gotten more review and was not
appropriate for -stable.
next prev parent reply other threads:[~2014-01-07 4:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 15:21 [PATCH net] vti: get rid of nf mark rule in prerouting Christophe Gouault
2013-10-08 16:48 ` Saurabh Mohan
2013-10-11 18:53 ` David Miller
2014-01-07 4:59 ` Stephen Hemminger [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-05-02 13:57 Brad Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140106205932.29553fd2@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber$(echo .)org \
--cc=amwang@redhat$(echo .)com \
--cc=christophe.gouault@6wind$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=saurabh@vyatta$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox