public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Steffen Klassert <steffen.klassert@secunet•com>
To: Fan Du <fan.du@windriver•com>
Cc: davem@davemloft•net, stephen@networkplumber•org,
	dev@lists•strongswan.org, netdev@vger•kernel.org
Subject: Re: [PATCH net-next 0/2] Pack struct xfrm_usersa_info and struct xfrm_userpolicy_info
Date: Tue, 7 Jan 2014 08:47:24 +0100	[thread overview]
Message-ID: <20140107074724.GV31491@secunet.com> (raw)
In-Reply-To: <1389077339-12814-1-git-send-email-fan.du@windriver.com>

On Tue, Jan 07, 2014 at 02:48:57PM +0800, Fan Du wrote:
> When trying to setup IPsec configuration on a 64bits host with
> iproute2(32bits compiled), the intened xfrm policy and sa is
> either deficit or wrong when kernel trying to parse user land
> information.
> 
> Further investigatino shows that:
> L: kernel
> R: iproute2
> 
>           sizeof       userpolicy      usersa
> 64bits(unpacked)        168/168        224/224
> 32bits(unpacked)        164/164        220/220
>                          ^   ^
>                          L   R
> 
> To keep kernel and user land see a consistent structure, after
> add packing attribute, now it looks like this:
> 
> 64bits(  packed)        164/164        217/217
> 32bits(  packed)        164/164        217/217
>                          ^   ^
>                          L   R
> 

We don't change userspace exported structures. This breaks
existing userspace tools.

  parent reply	other threads:[~2014-01-07  7:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-07  6:48 [PATCH net-next 0/2] Pack struct xfrm_usersa_info and struct xfrm_userpolicy_info Fan Du
2014-01-07  6:48 ` [PATCH net-next 1/2] include/uapi/linux/xfrm.h: Pack " Fan Du
2014-01-07 22:52   ` Sergei Shtylyov
2014-01-09  8:39     ` Fan Du
2014-01-09 22:58       ` Sergei Shtylyov
2014-01-09 23:07         ` Sergei Shtylyov
2014-01-07  6:48 ` [PATCH net-next 2/2] include/uapi/linux/xfrm.h: Pack struct xfrm_usersa_info Fan Du
2014-01-08 20:33   ` Ben Hutchings
2014-01-09  8:24     ` Fan Du
2014-01-09 18:58       ` Ben Hutchings
2014-01-07  6:55 ` [PATCH net-next 0/2] Pack struct xfrm_usersa_info and struct xfrm_userpolicy_info Fan Du
2014-01-07  7:47 ` Steffen Klassert [this message]
2014-01-07  7:59   ` Fan Du
2014-01-07 10:00     ` David Laight
2014-01-09  8:34       ` Fan Du
2014-01-09  9:07         ` David Laight
2014-01-07 18:07 ` David Miller
2014-01-09  8:24   ` Fan Du

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140107074724.GV31491@secunet.com \
    --to=steffen.klassert@secunet$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=dev@lists$(echo .)strongswan.org \
    --cc=fan.du@windriver$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=stephen@networkplumber$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox