From: Hannes Frederic Sowa <hannes@stressinduktion•org>
To: Jiri Pirko <jiri@resnulli•us>
Cc: Thomas Haller <thaller@redhat•com>,
netdev@vger•kernel.org, stephen@networkplumber•org,
dcbw@redhat•com
Subject: Re: [PATCH 1/1] ipv6 addrconf: add IFA_F_NOPREFIXROUTE flag to suppress creation of IP6 routes
Date: Tue, 7 Jan 2014 10:39:42 +0100 [thread overview]
Message-ID: <20140107093942.GA24730@order.stressinduktion.org> (raw)
In-Reply-To: <20140106173837.GA2571@minipsycho.orion>
On Mon, Jan 06, 2014 at 06:38:37PM +0100, Jiri Pirko wrote:
> Mon, Jan 06, 2014 at 06:29:35PM CET, thaller@redhat•com wrote:
> >When adding/modifying an IPv6 address, the userspace application needs
> >a way to suppress adding a prefix route. This is for example relevant
> >together with IFA_F_MANAGERTEMPADDR, where userspace creates autoconf
> >generated addresses, but depending on on-link, no route should for the
> >prefix should be added.
> >
> >This flag will not be set as ifa_flags of the address, it is only
> >considered as parameter while adding/modifying an address.
> >
> >Signed-off-by: Thomas Haller <thaller@redhat•com>
> >---
> > Hi, how about this?
> >
> > The flag is only a parameter for the netlink command.
> > This might be unexpected, because when adding an address,
> > you won't see the flag in `ip -6 addr`.
> > Still, I think, it is better to do it this way, because having
> > an address with the NOPREFIXROUTE flag, does not mean, that
> > there is no route for this prefix. It only means, that at the
> > moment of setting the address, no route was added.
> >
> > The alternative would be, not to add a prefix route, when
> > IFA_F_MANAGERTEMPADDR is set.
Looks good, maybe you could apply Jiri's feedback.
Otherwise we could skip trying to find a corresponding prefix route in
ipv6_del_addr. You would need to add the IFA_F_NOPREFIXROUTE test just before
the addrconf_get_prefix_route and ip6_del_rt.
Greetings,
Hannes
next prev parent reply other threads:[~2014-01-07 9:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-02 15:34 [patch iproute2 v2 0/2] add support for IFA_F_MANAGETEMPADDR Jiri Pirko
2014-01-02 15:34 ` [patch iproute2 v2 1/2] add support for extended ifa_flags Jiri Pirko
2014-01-02 15:34 ` [patch iproute2 v2 2/2] add support for IFA_F_MANAGETEMPADDR Jiri Pirko
2014-01-02 15:50 ` [PATCH 1/1] fixup! " Thomas Haller
2014-01-04 10:44 ` Jiri Pirko
2014-01-02 17:29 ` [patch iproute2 v2 0/2] " Hannes Frederic Sowa
2014-01-04 10:43 ` Jiri Pirko
2014-01-04 10:55 ` Hannes Frederic Sowa
2014-01-04 11:05 ` Jiri Pirko
2014-01-04 11:15 ` Hannes Frederic Sowa
2014-01-04 11:21 ` Thomas Haller
2014-01-04 11:35 ` Hannes Frederic Sowa
2014-01-06 15:41 ` Thomas Haller
2014-01-06 16:01 ` Hannes Frederic Sowa
2014-01-06 17:29 ` [PATCH 1/1] ipv6 addrconf: add IFA_F_NOPREFIXROUTE flag to suppress creation of IP6 routes Thomas Haller
2014-01-06 17:38 ` Jiri Pirko
2014-01-07 9:39 ` Hannes Frederic Sowa [this message]
2014-01-07 12:01 ` Hannes Frederic Sowa
2014-01-07 12:14 ` Thomas Haller
2014-01-07 12:22 ` Hannes Frederic Sowa
2014-01-07 14:39 ` [PATCH v2 0/2] " Thomas Haller
2014-01-07 14:39 ` [PATCH v2 1/2] " Thomas Haller
2014-01-07 14:39 ` [PATCH v2 2/2] ipv6 addrconf: don't cleanup route prefix for IFA_F_NOPREFIXROUTE Thomas Haller
2014-01-07 16:28 ` Hannes Frederic Sowa
2014-01-07 18:32 ` Thomas Haller
2014-01-07 19:01 ` Hannes Frederic Sowa
2014-01-07 22:54 ` Thomas Haller
2014-01-07 23:09 ` Hannes Frederic Sowa
2014-01-07 16:03 ` [PATCH v2 0/2] ipv6 addrconf: add IFA_F_NOPREFIXROUTE flag to suppress creation of IP6 routes Hannes Frederic Sowa
2014-01-07 21:42 ` Thomas Haller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140107093942.GA24730@order.stressinduktion.org \
--to=hannes@stressinduktion$(echo .)org \
--cc=dcbw@redhat$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
--cc=thaller@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox