From: Steffen Klassert <steffen.klassert@secunet•com>
To: David Miller <davem@davemloft•net>
Cc: dborkman@redhat•com, netdev@vger•kernel.org
Subject: Re: [PATCH net-next] net: xfrm: xfrm_policy: fix inline not at beginning of declaration
Date: Wed, 8 Jan 2014 06:55:36 +0100 [thread overview]
Message-ID: <20140108055536.GX31491@secunet.com> (raw)
In-Reply-To: <20140107.183412.1584306758322996233.davem@davemloft.net>
On Tue, Jan 07, 2014 at 06:34:12PM -0500, David Miller wrote:
> From: Daniel Borkmann <dborkman@redhat•com>
> Date: Tue, 7 Jan 2014 23:20:27 +0100
>
> > Fix three warnings related to:
> >
> > net/xfrm/xfrm_policy.c:1644:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
> > net/xfrm/xfrm_policy.c:1656:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
> > net/xfrm/xfrm_policy.c:1668:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
> >
> > Just removing the inline keyword is sufficient as the compiler will
> > decide on its own about inlining or not.
> >
> > Signed-off-by: Daniel Borkmann <dborkman@redhat•com>
>
> Applied.
I have a fix for this warnings in the ipsec-next tree too:
commit 2f3ea9a95c58fd0e4bed18a9c9dfe53739fee3b2
Author: Weilong Chen <chenweilong@huawei•com>
Date: Tue Dec 24 09:43:50 2013 +0800
xfrm: checkpatch erros with inline keyword position
Signed-off-by: Weilong Chen <chenweilong@huawei•com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet•com>
Should I revert it, or do you want to solve the conflict when
I send the ipsec-next pull request?
next prev parent reply other threads:[~2014-01-08 5:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 22:20 [PATCH net-next] net: xfrm: xfrm_policy: fix inline not at beginning of declaration Daniel Borkmann
2014-01-07 23:34 ` David Miller
2014-01-08 5:55 ` Steffen Klassert [this message]
2014-01-08 5:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140108055536.GX31491@secunet.com \
--to=steffen.klassert@secunet$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dborkman@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox