From: Veaceslav Falico <vfalico@redhat•com>
To: Alexander Duyck <alexander.h.duyck@intel•com>
Cc: netdev@vger•kernel.org, Jiri Pirko <jiri@resnulli•us>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Nicolas Dichtel <nicolas.dichtel@6wind•com>
Subject: Re: [PATCH net-next] net: make dev_set_mtu() honor notification return code
Date: Fri, 10 Jan 2014 16:47:42 +0100 [thread overview]
Message-ID: <20140110154742.GE4132@redhat.com> (raw)
In-Reply-To: <52D0138D.6050302@intel.com>
On Fri, Jan 10, 2014 at 07:36:45AM -0800, Alexander Duyck wrote:
>On 01/10/2014 04:48 AM, Veaceslav Falico wrote:
...snip...
>> - err = 0;
>> - if (ops->ndo_change_mtu)
>> - err = ops->ndo_change_mtu(dev, new_mtu);
>> - else
>> - dev->mtu = new_mtu;
>> + orig_mtu = dev->mtu;
>> + err = __dev_set_mtu(dev, new_mtu);
>>
>> - if (!err)
>> - call_netdevice_notifiers(NETDEV_CHANGEMTU, dev);
>> + if (!err) {
>> + err = call_netdevice_notifiers(NETDEV_CHANGEMTU, dev);
>> + err = notifier_to_errno(err);
>> + if (err)
>> + __dev_set_mtu(dev, orig_mtu);
>> + }
>> return err;
>> }
>> EXPORT_SYMBOL(dev_set_mtu);
>
>So what about the netdevices that succeeded in changing the MTU based on
>the notifiers? It seems like you still have an inconsistent state
>after the failure unless you issue a second call with a notification
>that you reverted to the old MTU.
Good point, thank you. I'll add a second call_netdevice_notifiers() after
setting the original MTU and resend.
Thank you!
>
>Thanks,
>
>Alex
next prev parent reply other threads:[~2014-01-10 15:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 12:48 [PATCH net-next] net: make dev_set_mtu() honor notification return code Veaceslav Falico
2014-01-10 15:36 ` Alexander Duyck
2014-01-10 15:47 ` Veaceslav Falico [this message]
2014-01-13 23:18 ` David Miller
2014-01-14 12:13 ` Veaceslav Falico
2014-01-15 21:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140110154742.GE4132@redhat.com \
--to=vfalico@redhat$(echo .)com \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.dichtel@6wind$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox