From: Steffen Klassert <steffen.klassert@secunet•com>
To: Fan Du <fan.du@windriver•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org
Subject: Re: [PATCHv3 net-next 2/5] {IPv4,xfrm} Add ESN support for AH ingress part
Date: Tue, 14 Jan 2014 11:51:02 +0100 [thread overview]
Message-ID: <20140114105102.GK31491@secunet.com> (raw)
In-Reply-To: <52D5144B.605@windriver.com>
On Tue, Jan 14, 2014 at 06:41:15PM +0800, Fan Du wrote:
>
>
> On 2014年01月14日 18:34, Steffen Klassert wrote:
> >On Tue, Jan 14, 2014 at 06:17:26PM +0800, Fan Du wrote:
> >>On 2014年01月14日 18:09, Steffen Klassert wrote:
> >
> >No, I mean something like:
> >
> >sg_init_table(sg, nfrags + sglists)
> >
> >if (x->props.flags& XFRM_STATE_ESN) {
> > *seqhi = XFRM_SKB_CB(skb)->seq.input.hi;
> > sg_set_buf(sg + nfrags, seqhi, seqhi_len);
> >}
> >
>
> hehe, it's the same as the option this patch used.
No, you don't need to sg_unmark_end() before you can add
your entry and it is more obvious what happens here.
Also, I'm not absolutely sure whether the sg magic allows
what you did. Did you test with sg debugging enabled?
> Anyway, I will make it as you suggested in the next round review.
>
Thanks!
next prev parent reply other threads:[~2014-01-14 10:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 1:39 [PATCHv3 net-next 0/5] xfrm: Add ESN support for AH Fan Du
2014-01-14 1:39 ` [PATCHv3 net-next 1/5] {IPv4,xfrm} Add ESN support for AH egress part Fan Du
2014-01-14 1:39 ` [PATCHv3 net-next 2/5] {IPv4,xfrm} Add ESN support for AH ingress part Fan Du
2014-01-14 9:54 ` Steffen Klassert
2014-01-14 10:01 ` Fan Du
2014-01-14 10:09 ` Steffen Klassert
2014-01-14 10:17 ` Fan Du
2014-01-14 10:34 ` Steffen Klassert
2014-01-14 10:41 ` Fan Du
2014-01-14 10:51 ` Steffen Klassert [this message]
2014-01-15 7:12 ` Fan Du
2014-01-14 1:39 ` [PATCHv3 net-next 3/5] {IPv6,xfrm} Add ESN support for AH egress part Fan Du
2014-01-14 1:39 ` [PATCHv3 net-next 4/5] {IPv6,xfrm} Add ESN support for AH ingress part Fan Du
2014-01-14 1:39 ` [PATCHv3 net-next 5/5] xfrm: Don't prohibit AH from using ESN feature Fan Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140114105102.GK31491@secunet.com \
--to=steffen.klassert@secunet$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=fan.du@windriver$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox