Subject: Re: [Patch net-next v2 3/5] net_sched: act: move tcf_hashinfo_init() into tcf_register_action()

From: Stephen Hemminger <[email-masked]>
Date: Thu, 23 Jan 2014 16:08:59 -0800

On Thu, 23 Jan 2014 14:35:23 -0800
Cong Wang <[email-masked]> wrote:

>  
>  struct tc_action {
>  	void			*priv;
> -	const struct tc_action_ops	*ops;
> +	struct tc_action_ops	*ops;

As much as possible all function tables should be constant.
One of the rootkit tricks is to overwrite a function table entry
at runtime. Granted tc action is a minor corner of the exposed
universe, but this seems a step backwards when the only real
gain is some refactoring/cleanup.