From: Jason Gunthorpe <jgunthorpe@obsidianresearch•com>
To: Florian Fainelli <f.fainelli@gmail•com>
Cc: Rob Herring <robh+dt@kernel•org>,
Grant Likely <grant.likely@linaro•org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH 2/2] of_mdio: Allow the DT to specify the phy ID and avoid autoprobing
Date: Fri, 31 Jan 2014 18:01:50 -0700 [thread overview]
Message-ID: <20140201010150.GB2519@obsidianresearch.com> (raw)
In-Reply-To: <CAGVrzcZwkHSLJxpVsVY_6-VnsuODs0vGKcrcvSBzMEq3GWxqLA@mail.gmail.com>
On Fri, Jan 31, 2014 at 03:28:10PM -0800, Florian Fainelli wrote:
> - you tell of_mdiobus_register() to look for a reset phandle and have
> a reset controller release the PHY from reset before it tries to probe
> for it, because doing that could avoid doing the PHY out of reset
> sequence in a few dozen Ethernet drivers
I think this would be interesting, but difficult. Ideally you'd want
to keep the phy in reset until an ethernet driver attaches to it, and
reset it again once it detaches, so Linux would have to defer probing
the phy driver until an attach. Not sure what this would do for power
consumption, but reset might be lower power on phy's that don't have
an internal power down.
> The auto-probing bypass logic looks simple enough, and it does not
> require burying the reset logic behind a reset controller, which
> uses
Right, it closely matches what was happening in board files. FWIW,
this system was designed in 2005 for Linux 2.16 and this patch set fell
out of porting forward to 3.13 w/ DT.
Jason
next prev parent reply other threads:[~2014-02-01 1:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 21:50 [PATCH v2 1/2] dt: Document a compatible entry for MDIO ethernet Phys Jason Gunthorpe
2014-01-31 21:50 ` [PATCH 2/2] of_mdio: Allow the DT to specify the phy ID and avoid autoprobing Jason Gunthorpe
2014-01-31 22:24 ` Florian Fainelli
2014-01-31 22:55 ` Jason Gunthorpe
2014-01-31 23:28 ` Florian Fainelli
2014-02-01 1:01 ` Jason Gunthorpe [this message]
[not found] ` <1391205045-1751-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2014-01-31 22:30 ` [PATCH v2 1/2] dt: Document a compatible entry for MDIO ethernet Phys Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140201010150.GB2519@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=grant.likely@linaro$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=robh+dt@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox