From: liujunliang_ljl <liujunliang_ljl@163•com>
To: "Joe Perches" <joe@perches•com>
Cc: davem <davem@davemloft•net>, horms <horms@verge•net.au>,
romieu <romieu@fr•zoreil.com>,
gregkh <gregkh@linuxfoundation•org>,
netdev <netdev@vger•kernel.org>,
linux-usb <linux-usb@vger•kernel.org>,
linux-kernel <linux-kernel@vger•kernel.org>,
sunhecheng <sunhecheng@vip•126.com>
Subject: Re: Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800Device Driver Support
Date: Fri, 7 Feb 2014 11:13:07 +0800 [thread overview]
Message-ID: <201402071113053122628@163.com> (raw)
In-Reply-To: 1390899572.20150.97.camel@joe-AO722
Dear Joe ：
I'm sorry that I reply so late, because I have just spent new chinese year.
I will resubmit SR9800 Driver today.
Thanks a lot.
2014-02-07
liujunliang_ljl
发件人： Joe Perches
发送时间： 2014-01-28 16:59:38
收件人： liujunliang_ljl
抄送： davem; horms; romieu; gregkh; netdev; linux-usb; linux-kernel; sunhecheng
主题： Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800Device Driver Support
On Tue, 2014-01-28 at 16:36 +0800, liujunliang_ljl@163•com wrote:
> From: Liu Junliang <liujunliang_ljl@163•com>
trivial comments...
> diff --git a/drivers/net/usb/sr9800.c b/drivers/net/usb/sr9800.c
[]
> +static int sr_rx_fixup(struct usbnet *dev, struct sk_buff *skb)
> +{
[]
> + if (size != ((~header >> 16) & 0x07ff)) {
> + netdev_err(dev->net,
> + "sr_rx_fixup() Bad Header Length\n");
printks with embedded functions names are
generally better using "%s: ", __func__
netdev_err(dev->net, "%s: Bad header length\n",
__func__);
[]
> + netdev_err(dev->net,
> + "sr_rx_fixup() Bad RX Length %d\n", size);
etc.
> + if (skb->len != offset) {
> + netdev_err(dev->net, "sr_rx_fixup() Bad SKB Length %d\n",
> + skb->len);
etc.
[]
> +static inline int sr9800_set_default_mode(struct usbnet *dev)
> +{
rather a big function to inline
[]
> + if (ret < 0) {
> + netdev_dbg(dev->net, "Write IPG,IPG1,IPG2 failed: %d", ret);
missing newline terminations
> + netdev_dbg(dev->net, "RX_CTL is 0x%04x after all initializations",
> + rx_ctl);
etc...
next prev parent reply other threads:[~2014-02-07 3:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 8:36 [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 Device Driver Support liujunliang_ljl
2014-01-28 8:59 ` Joe Perches
2014-02-07 3:13 ` liujunliang_ljl [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-02-10 5:33 liujunliang_ljl
2014-02-10 5:47 ` Joe Perches
2014-02-10 6:32 ` Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800Device " liujunliang_ljl
2014-02-10 6:31 [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 Device " liujunliang_ljl
2014-02-11 0:53 ` David Miller
2014-02-11 5:59 ` Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800Device " liujunliang_ljl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201402071113053122628@163.com \
--to=liujunliang_ljl@163$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=horms@verge$(echo .)net.au \
--cc=joe@perches$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=romieu@fr$(echo .)zoreil.com \
--cc=sunhecheng@vip$(echo .)126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox