Subject: Re: [PATCH net 1/3] kref: add kref_sub_return

From: Jörn Engel <[email-masked]>
Date: Wed, 12 Feb 2014 20:25:48 -0500

On Wed, 12 February 2014 19:06:37 -0500, David Miller wrote:
> 
> It isn't being used to determine when to destroy things.
> 
> They use it to as a heuristic of when to trigger polling.
> 
> Each ubuf attached gets a kref to the higher level virtio_net buffer
> holding object, they want to trigger polling when that reference drops
> to 1 or lower.
> 
> Right now they are reading the atomic refcount directly, which
> I think is much worse than this helper.

I disagree.  Reading the refcount directly is leaving noone under any
illusion that this might be a good idea.

Jörn

--
Victory in war is not repetitious.
-- Sun Tzu
_______________________________________________
Virtualization mailing list
[email-masked]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization