Subject: Re: Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 DeviceDriver Support

From: "liujunliang_ljl" <[email-masked]>
Date: Thu, 13 Feb 2014 12:23:44 +0800

Dear Thierry :

			For this driver, we can set it as 'n', and There is no rule of thumb as to which should default to y.

			Thanks for your advice.

			Thanks again.

2014-02-13 

liujunliang_ljl 

发件人： Thierry Reding 
发送时间： 2014-02-12  18:12:52 
收件人： liujunliang_ljl 
抄送： davem; horms; joe; romieu; gregkh; netdev; linux-usb; linux-kernel; sunhecheng 
主题： Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 DeviceDriver Support 
 
On Mon, Feb 10, 2014 at 01:33:39PM +0800, [email-masked] wrote:
> From: Liu Junliang <[email-masked]>
> 
> 
> Signed-off-by: Liu Junliang <[email-masked]>
> ---
>  drivers/net/usb/Kconfig  |   16 +
>  drivers/net/usb/Makefile |    1 +
>  drivers/net/usb/sr9800.c |  873 ++++++++++++++++++++++++++++++++++++++++++++++
>  drivers/net/usb/sr9800.h |  202 +++++++++++
>  4 files changed, 1092 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/net/usb/sr9800.c
>  create mode 100644 drivers/net/usb/sr9800.h
> 
> diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
> index 47b0f73..2551bf6 100644
> --- a/drivers/net/usb/Kconfig
> +++ b/drivers/net/usb/Kconfig
> @@ -291,6 +291,22 @@ config USB_NET_SR9700
>     This option adds support for CoreChip-sz SR9700 based USB 1.1
>     10/100 Ethernet adapters.
>  
> +config USB_NET_SR9800
> + tristate "CoreChip-sz SR9800 based USB 2.0 10/100 ethernet devices"
> + depends on USB_USBNET
> + select CRC32
> + default y
Why is this selected by default? I can see that some of the other USB
network drivers are also selected by default, but not all of them. Is
there some rule of thumb as to which should default to y and which
shouldn't?
Thierry