From: Jiri Bohac <jbohac@suse•cz>
To: Flavio Leitner <fbl@redhat•com>
Cc: Jay Vosburgh <fubar@us•ibm.com>,
Veaceslav Falico <vfalico@redhat•com>,
Andy Gospodarek <andy@greyhouse•net>,
netdev@vger•kernel.org
Subject: Re: [PATCH] bonding: 802.3ad: make aggregator_identifier bond-private
Date: Fri, 14 Feb 2014 21:51:47 +0100 [thread overview]
Message-ID: <20140214205147.GA1798@midget.suse.cz> (raw)
In-Reply-To: <20140214191243.GA3173@localhost.localdomain>
On Fri, Feb 14, 2014 at 05:12:43PM -0200, Flavio Leitner wrote:
> On Fri, Feb 14, 2014 at 06:13:50PM +0100, Jiri Bohac wrote:
> > Fix this by making aggregator_identifier private to the bond.
>
> I don't see how you fix the duplicate agg id with this patch because
> you initialize for each bond to 0, then use the same algo further on.
> So, what is changing?
My understanding is that the aggregator identifier is used
internally by the bond and never appears anywhere in the LACP
traffic.
So having duplicate aggregator ids between two bonds on the same
machine does not matter. But it is a problem if two aggregators
in the same bond share the same id.
Is my understanding wrong?
> Actually, aggregator_identifier is a global variable to make sure the
> counter is always increasing for new bonds. So, the fix would be to
> not reset it to zero, isn't it?
I was considering this fix, but my concern was that the variable
(u16) would overflow sooner than it does now. It would take 2^16
enslavings on the machine, while with my patch you need 2^16
enslavings on a single bond.
Hypothetically, a rogue NET_ADMIN in one net namespace may cause
this overflow to break a bond in another nemespace.
Maybe I'm being paranoid? ;)
--
Jiri Bohac <jbohac@suse•cz>
SUSE Labs, SUSE CZ
--
Jiri Bohac <jbohac@suse•cz>
SUSE Labs, SUSE CZ
next prev parent reply other threads:[~2014-02-14 20:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 17:13 [PATCH] bonding: 802.3ad: make aggregator_identifier bond-private Jiri Bohac
2014-02-14 17:18 ` Veaceslav Falico
2014-02-14 19:12 ` Flavio Leitner
2014-02-14 20:51 ` Jiri Bohac [this message]
2014-02-14 21:16 ` Jay Vosburgh
2014-02-14 21:48 ` Flavio Leitner
2014-02-17 19:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140214205147.GA1798@midget.suse.cz \
--to=jbohac@suse$(echo .)cz \
--cc=andy@greyhouse$(echo .)net \
--cc=fbl@redhat$(echo .)com \
--cc=fubar@us$(echo .)ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vfalico@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox