From: Stephen Hemminger <stephen@networkplumber•org>
To: Michal Kubecek <mkubecek@suse•cz>
Cc: netdev@vger•kernel.org, Ding Tianhong <dingtianhong@huawei•com>
Subject: Re: [PATCH iproute2 v2] iplink_bond: fix parameter value matching
Date: Mon, 17 Feb 2014 11:00:03 -0800 [thread overview]
Message-ID: <20140217110003.320dcd20@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <20140213163159.7F73CE668E@unicorn.suse.cz>
On Thu, 13 Feb 2014 17:31:59 +0100 (CET)
Michal Kubecek <mkubecek@suse•cz> wrote:
> Lookup function get_index() compares argument with table entries
> only up to the length of the table entry so that if an entry
> with lower index is a substring of a later one, earlier entry is
> used even if the argument is equal to the other. For example,
>
> ip link set bond0 type bond xmit_hash_policy layer2+3
>
> sets xmit_hash_policy to 0 (layer2) as this is found before
> "layer2+3" can be checked.
>
> Use strcmp() to compare whole strings instead.
>
> v2: look for an exact match only
>
> Signed-off-by: Michal Kubecek <mkubecek@suse•cz>
Applied
prev parent reply other threads:[~2014-02-17 19:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 12:59 [PATCH iproute2 net-next-for-3.13] iplink_bond: fix parameter value matching Michal Kubecek
2014-02-07 2:45 ` Ding Tianhong
2014-02-13 16:31 ` [PATCH iproute2 v2] " Michal Kubecek
2014-02-17 19:00 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140217110003.320dcd20@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber$(echo .)org \
--cc=dingtianhong@huawei$(echo .)com \
--cc=mkubecek@suse$(echo .)cz \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox