public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Alexander Aring <alex.aring@gmail•com>
To: David Laight <David.Laight@ACULAB•COM>
Cc: "alex.bluesman.smirnov@gmail•com"
	<alex.bluesman.smirnov@gmail•com>,
	"dbaryshkov@gmail•com" <dbaryshkov@gmail•com>,
	"davem@davemloft•net" <davem@davemloft•net>,
	"linux-zigbee-devel@lists•sourceforge.net"
	<linux-zigbee-devel@lists•sourceforge.net>,
	"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
	"martin.townsend@xsilon•com" <martin.townsend@xsilon•com>
Subject: Re: [PATCH net-next v4 2/8] 6lowpan: add uncompress header size function
Date: Wed, 26 Feb 2014 17:20:10 +0100	[thread overview]
Message-ID: <20140226162008.GA11499@omega> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D0F6CBBCA@AcuExch.aculab.com>

Hi David,

thanks for your reply.

On Wed, Feb 26, 2014 at 04:10:05PM +0000, David Laight wrote:
> From: Alexander Aring
> > Signed-off-by: Alexander Aring <alex.aring@gmail•com>
> > ---
> >  net/ieee802154/6lowpan.h | 116 +++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 116 insertions(+)
> > 
> > diff --git a/net/ieee802154/6lowpan.h b/net/ieee802154/6lowpan.h
> > index 2b835db..b6ae0bc 100644
> > --- a/net/ieee802154/6lowpan.h
> > +++ b/net/ieee802154/6lowpan.h
> > @@ -306,6 +306,122 @@ static inline void lowpan_push_hc_data(u8 **hc_ptr, const void *data,
> >  	*hc_ptr += len;
> >  }
> > 
> > +static inline u8 lowpan_addr_mode_size(const u8 addr_mode)
> > +{
> > +	switch (addr_mode) {
> > +	case LOWPAN_IPHC_ADDR_00:
> > +		return 16;
> > +	case LOWPAN_IPHC_ADDR_01:
> > +		return 8;
> > +	case LOWPAN_IPHC_ADDR_02:
> > +		return 2;
> > +	default:
> > +		return 0;
> > +	}
> > +}
> 
> The compiler will generate much better code if you index an array instead
> of using a switch statement.
> 
> 

You mean something like:

static inline u8 lowpan_addr_mode_size(const u8 addr_mode)
{
        const u8 res[] = { 16, 8, 2, 0 };
        return res[addr_mode];
}

or should I drop the array from the stack and declare it static?

?

- Alex

next prev parent reply	other threads:[~2014-02-26 16:20 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-26 16:05 [PATCH net-next v4 0/8] 6lowpan: reimplementation of fragmentation handling Alexander Aring
2014-02-26 16:05 ` [PATCH net-next v4 2/8] 6lowpan: add uncompress header size function Alexander Aring
2014-02-26 16:10   ` David Laight
2014-02-26 16:20     ` Alexander Aring [this message]
2014-02-26 17:05       ` David Laight
2014-02-26 18:24     ` Joe Perches
2014-02-26 18:32       ` Alexander Aring
2014-02-26 18:35         ` Joe Perches
2014-02-26 18:56     ` David Miller
2014-02-26 16:05 ` [PATCH net-next v4 3/8] 6lowpan: fix fragmentation on sending side Alexander Aring
2014-02-26 16:05 ` [PATCH net-next v4 5/8] 6lowpan: move 6lowpan.c to 6lowpan_rtnl.c Alexander Aring
     [not found] ` <1393430712-11298-1-git-send-email-alex.aring-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-02-26 16:05   ` [PATCH net-next v4 1/8] 6lowpan: add frag information struct Alexander Aring
2014-02-26 16:05   ` [PATCH net-next v4 4/8] 6lowpan: change tag type to __be16 Alexander Aring
2014-02-26 16:05   ` [PATCH net-next v4 6/8] 6lowpan: fix some checkpatch issues Alexander Aring
     [not found]     ` <1393430712-11298-7-git-send-email-alex.aring-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-02-26 17:24       ` Joe Perches
2014-02-26 18:59         ` David Miller
2014-02-26 16:05 ` [PATCH net-next v4 7/8] net: ns: add ieee802154_6lowpan namespace Alexander Aring
2014-02-26 16:05 ` [PATCH net-next v4 8/8] 6lowpan: handling 6lowpan fragmentation via inet_frag api Alexander Aring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140226162008.GA11499@omega \
    --to=alex.aring@gmail$(echo .)com \
    --cc=David.Laight@ACULAB$(echo .)COM \
    --cc=alex.bluesman.smirnov@gmail$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=dbaryshkov@gmail$(echo .)com \
    --cc=linux-zigbee-devel@lists$(echo .)sourceforge.net \
    --cc=martin.townsend@xsilon$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox