Subject: Re: [PATCH net-next] bonding: send arp requests even if there's no route to them

From: Veaceslav Falico <[email-masked]>
Date: Fri, 28 Feb 2014 12:28:40 +0100

On Fri, Feb 28, 2014 at 03:12:51AM -0800, Joe Perches wrote:
>On Fri, 2014-02-28 at 11:57 +0100, Veaceslav Falico wrote:
...snip...
>> +			if (bond->params.arp_validate)
>> +				pr_warn("%s: no route to arp_ip_target %pI4 and arp_validate is set\n",
>> +					bond->dev->name, &targets[i]);
>
>Maybe
>
>			if (bond->params.arp_validate && net_ratelimit())

Hm, not that I'm against it - but bond_arp_send_all() is called every
arp_interval - which is usually >50ms. Does it really make sense to put it
here?

Thanks for a quick review!