From: Richard Cochran <richardcochran@gmail•com>
To: Andy Lutomirski <luto@amacapital•net>
Cc: Network Development <netdev@vger•kernel.org>
Subject: Re: What is SOF_TIMESTAMPING_RX_HARDWARE?
Date: Tue, 4 Mar 2014 11:10:30 +0100 [thread overview]
Message-ID: <20140304101030.GA8532@netboy> (raw)
In-Reply-To: <CALCETrULL_QJqSLSCcySdUdj5sGgh8A7gyEn=vpgCC4LDjPHFA@mail.gmail.com>
On Mon, Mar 03, 2014 at 06:20:33PM -0800, Andy Lutomirski wrote:
> AFAICT is sets SOCK_TIMESTAMPING_RX_HARDWARE, which appears to do
> exactly nothing. If I'm right, should I submit a patch documenting
> that fact and removing the getsockopt/setsockopt implementations?
Have you seen Documentation/networking/timestamping.txt?
SOF_TIMESTAMPING_TX/RX determine how time stamps are generated.
SOF_TIMESTAMPING_RAW/SYS determine how they are reported in the
following control message:
This is the API that was invented (not by me) to support HW time stamp
reporting. I agree that it is confusing and complicated, but I don't
think you can remove the flag as it is a firmly established API.
Drivers do use this to advertise whether they support receive time
stamps in hardware.
AFAICT, the reason why setting this socket option is a noop is
this. Once receive time stamping is enabled at the driver level,
eligible skbs will get the information whether they want it or not.
It would be more work to hide this from sockets which haven't enabled
the option, and so we don't do it.
HTH,
Richard
next prev parent reply other threads:[~2014-03-04 10:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 2:20 What is SOF_TIMESTAMPING_RX_HARDWARE? Andy Lutomirski
2014-03-04 10:10 ` Richard Cochran [this message]
2014-03-04 17:21 ` Andy Lutomirski
2014-03-04 17:38 ` Richard Cochran
2014-03-04 17:42 ` Richard Cochran
2014-03-04 17:45 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140304101030.GA8532@netboy \
--to=richardcochran@gmail$(echo .)com \
--cc=luto@amacapital$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox