Subject: Re: [PATCH net] ipv6: don't set DST_NOCOUNT for remotely added routes

From: Sabrina Dubroca <[email-masked]>
Date: Thu, 6 Mar 2014 22:03:17 +0100

2014-03-06, 15:27:15 -0500, David Miller wrote:
> From: Sabrina Dubroca <[email-masked]>
> Date: Thu,  6 Mar 2014 17:51:57 +0100
> 
> > DST_NOCOUNT should only be used if an authorized user adds routes
> > locally. In case of routes which are added on behalf of router
> > advertisments this flag must not get used as it allows an unlimited
> > number of routes getting added remotely.
> > 
> > Signed-off-by: Sabrina Dubroca <[email-masked]>
> > Acked-by: Hannes Frederic Sowa <[email-masked]>
> > ---
> > 
> > Hannes suggested this for stable
> 
> This seems to conflict with the intentions of:
> 
> commit a3300ef4bbb1f1e33ff0400e1e6cf7733d988f4f
> Author: Hannes Frederic Sowa <[email-masked]>
> Date:   Sat Dec 7 03:33:45 2013 +0100
> 
>     ipv6: don't count addrconf generated routes against gc limit
> 
> If not, why not?

These are not the same routes. The commit you mention is for the
routes added to the loopback device in the local table (limited by
max_addresses as the log says).

This patch limits the number of "real" routes that can be added,
which is currently unlimited.

-- 
Sabrina