From: Hannes Frederic Sowa <hannes@stressinduktion•org>
To: Heiner Kallweit <heiner.kallweit@web•de>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH] ipv6: simplify code structure in addrconf.c/manage_tempaddrs
Date: Mon, 31 Mar 2014 21:21:39 +0200 [thread overview]
Message-ID: <20140331192139.GD24150@order.stressinduktion.org> (raw)
In-Reply-To: <5339B84E.7030708@web.de>
On Mon, Mar 31, 2014 at 08:47:42PM +0200, Heiner Kallweit wrote:
> read_unlock_bh can be moved out of the if clause
>
> Signed-off-by: Heiner Kallweit <heiner.kallweit@web•de>
> ---
> net/ipv6/addrconf.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index 6c7fa08..a65812f 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -2122,6 +2122,7 @@ static void manage_tempaddrs(struct inet6_dev *idev,
> if (!(flags&IFA_F_TENTATIVE))
> ipv6_ifa_notify(0, ift);
> }
> + read_unlock_bh(&idev->lock);
>
> if ((create || list_empty(&idev->tempaddr_list)) &&
> idev->cnf.use_tempaddr > 0) {
> @@ -2130,10 +2131,7 @@ static void manage_tempaddrs(struct inet6_dev *idev,
> * Also create a temporary address if it's enabled but
> * no temporary address currently exists.
> */
> - read_unlock_bh(&idev->lock);
> ipv6_create_tempaddr(ifp, NULL);
> - } else {
> - read_unlock_bh(&idev->lock);
Doesn't the lock also protect the list_empty? I remember there is
a list_empty_careful to check concurrently if empty during possible
modification. I actually would leave it as is.
Thanks,
Hannes
next prev parent reply other threads:[~2014-03-31 19:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 18:47 [PATCH] ipv6: simplify code structure in addrconf.c/manage_tempaddrs Heiner Kallweit
2014-03-31 19:21 ` Hannes Frederic Sowa [this message]
2014-03-31 19:27 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140331192139.GD24150@order.stressinduktion.org \
--to=hannes@stressinduktion$(echo .)org \
--cc=heiner.kallweit@web$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox