public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation•org>
To: Vlad Yasevich <vyasevich@gmail•com>,
	Jiri Pirko <jiri@resnulli•us>,
	Nicolas Dichtel <nicolas.dichtel@6wind•com>
Cc: David Miller <davem@davemloft•net>, netdev@vger•kernel.org
Subject: net-core-rtnetlinkc-copy-paste-error-in-rtnl_bridge_notify.patch
Date: Thu, 3 Apr 2014 12:01:22 -0700	[thread overview]
Message-ID: <20140403120122.fe50ce80260faf3fc3a4ae30@linux-foundation.org> (raw)



Guys, I've been sitting on this since January and simply cannot
remember what happened with it.  Is this still a thing or did it get
nacked, or...?

Thanks.


From: Yogesh Gaur <yogeshgaur.83@gmail•com>
Subject: net/core/rtnetlink.c: copy paste error in rtnl_bridge_notify()

Seems to be copy paste error in calling ndo_bridge_getlink() func.

Signed-off-by: Yogesh Gaur <yogeshgaur.83@gmail•com>
Cc: "David S. Miller" <davem@davemloft•net>
Cc: Vlad Yasevich <vyasevich@gmail•com>
Cc: Jiri Pirko <jiri@resnulli•us>
Cc: Nicolas Dichtel <nicolas.dichtel@6wind•com>
Signed-off-by: Andrew Morton <akpm@linux-foundation•org>
---

 net/core/rtnetlink.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN net/core/rtnetlink.c~net-core-rtnetlinkc-copy-paste-error-in-rtnl_bridge_notify net/core/rtnetlink.c
--- a/net/core/rtnetlink.c~net-core-rtnetlinkc-copy-paste-error-in-rtnl_bridge_notify
+++ a/net/core/rtnetlink.c
@@ -2576,7 +2576,7 @@ static int rtnl_bridge_notify(struct net
 
 	if ((!flags || (flags & BRIDGE_FLAGS_MASTER)) &&
 	    br_dev && br_dev->netdev_ops->ndo_bridge_getlink) {
-		err = br_dev->netdev_ops->ndo_bridge_getlink(skb, 0, 0, dev, 0);
+		err = br_dev->netdev_ops->ndo_bridge_getlink(skb, 0, 0, br_dev, 0);
 		if (err < 0)
 			goto errout;
 	}
_

             reply	other threads:[~2014-04-03 19:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-03 19:01 Andrew Morton [this message]
2014-04-03 19:47 ` net-core-rtnetlinkc-copy-paste-error-in-rtnl_bridge_notify.patch Daniel Borkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140403120122.fe50ce80260faf3fc3a4ae30@linux-foundation.org \
    --to=akpm@linux-foundation$(echo .)org \
    --cc=davem@davemloft$(echo .)net \
    --cc=jiri@resnulli$(echo .)us \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=nicolas.dichtel@6wind$(echo .)com \
    --cc=vyasevich@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox