Subject: Re: [PATCH 2/3] staging: r8188eu: Fix case where ethtype was never obtained and always be checked against 0

From: Dan Carpenter <[email-masked]>
Date: Wed, 9 Apr 2014 22:02:04 +0300

On Wed, Apr 09, 2014 at 08:24:08PM +0400, Sergei Shtylyov wrote:
> >diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c b/drivers/staging/rtl8188eu/core/rtw_recv.c
> >index 01fcabc..61084d6 100644
> >--- a/drivers/staging/rtl8188eu/core/rtw_recv.c
> >+++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
> >@@ -551,7 +551,7 @@ static struct recv_frame *portctrl(struct adapter *adapter,
> >  	struct sta_info *psta;
> >  	struct sta_priv *pstapriv;
> >  	struct recv_frame *prtnframe;
> >-	u16	ether_type = 0;
> >+	u16	ether_type;
> 
>    I suggest:
> 
> 	u16 ethertype;
> 

I don't understand this suggestion.  Why is that name prefered?

regards,
dan carpenter