From: David Gibson <david@gibson•dropbear.id.au>
To: Jiri Pirko <jiri@resnulli•us>
Cc: netdev@vger•kernel.org, ssujith@cisco•com, neepatel@cisco•com,
benve@cisco•com, davem@davemloft•net, ben@decadent•org.uk,
govindarajulu90@gmail•com, gregory.v.rose@intel•com
Subject: Re: [PATCH 1/2] rtnetlink: Warn when interface's information won't fit in our packet
Date: Wed, 23 Apr 2014 21:41:20 +1000 [thread overview]
Message-ID: <20140423114120.GC31647@voom.fritz.box> (raw)
In-Reply-To: <20140423090905.GC2846@minipsycho.orion>
[-- Attachment #1: Type: text/plain, Size: 2475 bytes --]
On Wed, Apr 23, 2014 at 11:09:05AM +0200, Jiri Pirko wrote:
> Wed, Apr 23, 2014 at 09:21:04AM CEST, david@gibson•dropbear.id.au wrote:
> >Without IFLA_EXT_MASK specified, the information reported for a single
> >interface in response to RTM_GETLINK is expected to fit within a netlink
> >packet of NLMSG_GOODSIZE.
> >
> >If it doesn't, however, things will go badly wrong, When listing all
> >interfaces, netlink_dump() will incorrectly treat -EMSGSIZE on the first
> >message in a packet as the end of the listing and omit information for
> >that interface and all subsequent ones. This can cause getifaddrs(3) to
> >enter an infinite loop.
> >
> >This patch won't fix the problem, but it will WARN_ON() making it easier to
> >track down what's going wrong.
> >
> >Signed-off-by: David Gibson <david@gibson•dropbear.id.au>
> >---
> > net/core/rtnetlink.c | 16 +++++++++++-----
> > 1 file changed, 11 insertions(+), 5 deletions(-)
> >
> >diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
> >index d4ff417..5331db2 100644
> >--- a/net/core/rtnetlink.c
> >+++ b/net/core/rtnetlink.c
> >@@ -1198,6 +1198,7 @@ static int rtnl_dump_ifinfo(struct sk_buff *skb, struct netlink_callback *cb)
> > struct hlist_head *head;
> > struct nlattr *tb[IFLA_MAX+1];
> > u32 ext_filter_mask = 0;
> >+ int err;
> >
> > s_h = cb->args[0];
> > s_idx = cb->args[1];
> >@@ -1218,11 +1219,16 @@ static int rtnl_dump_ifinfo(struct sk_buff *skb, struct netlink_callback *cb)
> > hlist_for_each_entry_rcu(dev, head, index_hlist) {
> > if (idx < s_idx)
> > goto cont;
> >- if (rtnl_fill_ifinfo(skb, dev, RTM_NEWLINK,
> >- NETLINK_CB(cb->skb).portid,
> >- cb->nlh->nlmsg_seq, 0,
> >- NLM_F_MULTI,
> >- ext_filter_mask) <= 0)
> >+ err = rtnl_fill_ifinfo(skb, dev, RTM_NEWLINK,
> >+ NETLINK_CB(cb->skb).portid,
> >+ cb->nlh->nlmsg_seq, 0,
> >+ NLM_F_MULTI,
> >+ ext_filter_mask);
> >+ /* If we ran out of room on the first message,
> >+ * we're in trouble */
> >+ WARN_ON((err == -EMSGSIZE) && (skb->len == 0));
> >+
> >+ if (err <= 0)
> if (err)
<= 0 was what the original version had. Why do you think it should be
changed to != 0?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-04-23 11:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 7:21 [0/2] Fix problems with with IFLA_VF_PORTS David Gibson
2014-04-23 7:21 ` [PATCH 1/2] rtnetlink: Warn when interface's information won't fit in our packet David Gibson
2014-04-23 9:09 ` Jiri Pirko
2014-04-23 11:41 ` David Gibson [this message]
2014-04-23 11:51 ` Jiri Pirko
2014-04-23 14:20 ` Sergei Shtylyov
2014-04-23 7:21 ` [PATCH 2/2] rtnetlink: Only supply IFLA_VF_PORTS information when RTEXT_FILTER_VF is set David Gibson
2014-04-23 9:17 ` Jiri Pirko
2014-04-24 0:13 ` David Gibson
2014-04-23 15:14 ` [0/2] Fix problems with with IFLA_VF_PORTS Greg Rose
-- strict thread matches above, loose matches on Subject: below --
2014-04-24 0:22 [0/2] Fix problems with with IFLA_VF_PORTS (v2) David Gibson
2014-04-24 0:22 ` [PATCH 1/2] rtnetlink: Warn when interface's information won't fit in our packet David Gibson
2014-04-24 15:49 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423114120.GC31647@voom.fritz.box \
--to=david@gibson$(echo .)dropbear.id.au \
--cc=ben@decadent$(echo .)org.uk \
--cc=benve@cisco$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=govindarajulu90@gmail$(echo .)com \
--cc=gregory.v.rose@intel$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=neepatel@cisco$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ssujith@cisco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox