From: Wei Liu <wei.liu2@citrix•com>
To: "Andrew J. Bennieston" <andrew.bennieston@citrix•com>
Cc: <xen-devel@lists•xenproject.org>, <davem@davemloft•net>,
<ian.campbell@citrix•com>, <wei.liu2@citrix•com>,
<paul.durrant@citrix•com>, <netdev@vger•kernel.org>,
<david.vrabel@citrix•com>, <zoltan.kiss@citrix•com>
Subject: Re: [PATCH V7 net-next 4/7] xen-netback: Correctly clean up after queue initialisation error.
Date: Wed, 30 Apr 2014 15:49:54 +0100 [thread overview]
Message-ID: <20140430144954.GA19082@zion.uk.xensource.com> (raw)
In-Reply-To: <1398778035-26233-5-git-send-email-andrew.bennieston@citrix.com>
On Tue, Apr 29, 2014 at 02:27:12PM +0100, Andrew J. Bennieston wrote:
> From: "Andrew J. Bennieston" <andrew.bennieston@citrix•com>
>
> Multiple queues were introduced in the previous patch, but if the
> initialisation of a queue failed, earlier queues would not be cleaned
> up. This patch adds cleanup logic for this scenario, making use of code
> from the regular teardown sequence.
>
Shouldn't this patch be folded into that "previous patch" which
introduced this problem? I see you did this for netfront patch already.
Wei.
next prev parent reply other threads:[~2014-04-30 14:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 13:27 [PATCH V7 net-next] xen-net{back, front}: Multiple transmit and receive queues Andrew J. Bennieston
2014-04-29 13:27 ` [PATCH V7 net-next 1/7] xen-netback: Move grant_copy_op array back into struct xenvif Andrew J. Bennieston
2014-04-30 14:50 ` Wei Liu
2014-04-29 13:27 ` [PATCH V7 net-next 2/7] xen-netback: Factor queue-specific data into queue struct Andrew J. Bennieston
2014-04-29 13:27 ` [PATCH V7 net-next 3/7] xen-netback: Add support for multiple queues Andrew J. Bennieston
2014-04-29 13:27 ` [PATCH V7 net-next 4/7] xen-netback: Correctly clean up after queue initialisation error Andrew J. Bennieston
2014-04-30 14:49 ` Wei Liu [this message]
2014-04-30 16:46 ` Andrew Bennieston
2014-04-29 13:27 ` [PATCH V7 net-next 5/7] xen-netfront: Factor queue-specific data into queue struct Andrew J. Bennieston
2014-04-30 14:51 ` Wei Liu
2014-04-30 14:59 ` [Xen-devel] " David Vrabel
2014-04-29 13:27 ` [PATCH V7 net-next 6/7] xen-netfront: Add support for multiple queues Andrew J. Bennieston
2014-04-30 14:51 ` Wei Liu
2014-04-29 13:27 ` [PATCH V7 net-next 7/7] xen-net{back, front}: Document multi-queue feature in netif.h Andrew J. Bennieston
2014-04-30 14:51 ` [PATCH V7 net-next 7/7] xen-net{back,front}: " Wei Liu
2014-04-30 16:47 ` Andrew Bennieston
2014-04-30 14:50 ` [PATCH V7 net-next] xen-net{back,front}: Multiple transmit and receive queues Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140430144954.GA19082@zion.uk.xensource.com \
--to=wei.liu2@citrix$(echo .)com \
--cc=andrew.bennieston@citrix$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=david.vrabel@citrix$(echo .)com \
--cc=ian.campbell@citrix$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paul.durrant@citrix$(echo .)com \
--cc=xen-devel@lists$(echo .)xenproject.org \
--cc=zoltan.kiss@citrix$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox