From: "John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public•gmane.org>
To: Adam Lee <adam.lee-Z7WLFzj8eWMS+FvcfC7Uqw@public•gmane.org>
Cc: Stephen Hemminger
<stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public•gmane.org>,
Larry Finger
<Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public•gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
Subject: Re: [PATCH 1/3] rtlwifi: make MSI support a module parameter
Date: Tue, 6 May 2014 14:08:37 -0400 [thread overview]
Message-ID: <20140506180836.GF3518@tuxdriver.com> (raw)
In-Reply-To: <20140506021915.GA3624@adam-laptop>
On Tue, May 06, 2014 at 10:19:15AM +0800, Adam Lee wrote:
> On Mon, May 05, 2014 at 03:40:37PM -0700, Stephen Hemminger wrote:
> > On Mon, 05 May 2014 09:56:16 -0500
> > Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public•gmane.org> wrote:
> >
> > > On 05/05/2014 03:33 AM, Adam Lee wrote:
> > > > This makes MSI support a module parameter, for debugging and workaround
> > > > convenience.
> > > >
> > > > Signed-off-by: Adam Lee <adam.lee-Z7WLFzj8eWMS+FvcfC7Uqw@public•gmane.org>
> > >
> > > Acked-by: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public•gmane.org> (for all 3 patches)
> > >
> > > I would have made the default for the MSI option to be true, but that is a
> > > matter of preference, and only experience would show which default leads to the
> > > fewer failures. On my laptop, both rtl8188ee and rtl8723be work either way. I am
> > > now working on a driver for the RTL8192EE that also can use MSI - that has only
> > > been tested with the option on.
> > >
> > > Larry
> >
> > Standard practice is to assume MSI is available, and let the quirks
> > in the PCI subsystem reject the request to enable MSI.
> >
> > Also other drivers have a 'disable_msi' module parameter why not follow
> > their example.
> >
>
> Because some submodule's MSI causes an regression, and other submodules
> of rtlwifi are not fully tested under MSI, we need to disable it by
> default(regression has higher priority) and have an 'enable_msi' module
> parameter for some certain users.
Couldn't it be called 'disable_msi' and default to 'on'?
--
John W. Linville Someday the world will need a hero, and you
linville-2XuSBdqkA4R54TAoqtyWWQ@public•gmane.org might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-05-06 18:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 8:33 [PATCH 1/3] rtlwifi: make MSI support a module parameter Adam Lee
2014-05-05 8:33 ` [PATCH 2/3] rtlwifi: rtl8188ee: add msi " Adam Lee
[not found] ` <1399278818-19152-1-git-send-email-adam.lee-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2014-05-05 8:33 ` [PATCH 3/3] rtlwifi: rtl8723be: " Adam Lee
2014-05-05 14:56 ` [PATCH 1/3] rtlwifi: make MSI support a " Larry Finger
2014-05-05 22:40 ` Stephen Hemminger
2014-05-06 2:19 ` Adam Lee
2014-05-06 18:08 ` John W. Linville [this message]
2014-05-07 2:31 ` Adam Lee
2014-05-07 2:52 ` Adam Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140506180836.GF3518@tuxdriver.com \
--to=linville-2xusbdqka4r54taoqtywwq@public$(echo .)gmane.org \
--cc=Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public$(echo .)gmane.org \
--cc=adam.lee-Z7WLFzj8eWMS+FvcfC7Uqw@public$(echo .)gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox