Subject: Re: [PATCH v8 1/1] Driver for Beckhoff CX5020 EtherCAT master module.

From: Darek Marcinkiewicz <[email-masked]>
Date: Tue, 6 May 2014 22:18:15 +0200

On Tue, May 06, 2014 at 04:56:06PM +0200, Tobias Klauser wrote:
> > +		if (skb) {
> > +			memcpy(skb_put(skb, pkt_size), data, pkt_size);
> > +			skb->protocol = eth_type_trans(skb, priv->net_dev);
> > +			dev_dbg(dev, "Protocol type: %x\n", skb->protocol);
> > +
> > +			netif_rx(skb);
> > +		} else {
> > +			dev_err_ratelimited(dev,
> > +				"Couldn't allocate a skb_buff for a packet of size %u\n",
> > +				pkt_size);
> > +		}
> > +
> > +		priv->stat_rx_bytes += pkt_size;
> 
> This should only be incremented if the packet was actually passed to
> netif_rx(), no?
Yes, I guees it should.
> 
> > +
> > +static struct rtnl_link_stats64 *
> > +ec_bhf_get_stats(struct net_device *net_dev,
> > +		 struct rtnl_link_stats64 *stats)
> > +{
> > +	struct ec_bhf_priv *priv = netdev_priv(net_dev);
> > +
> > +	memset(stats, 0, sizeof(*stats));
> 
> No need to memset() here, this is already done in dev_get_stats()
> 
Ok, thanks. Will send updated patch.

-- 
DM