From: Stephen Hemminger <stephen@networkplumber•org>
To: Jay Vosburgh <jay.vosburgh@canonical•com>
Cc: netdev@vger•kernel.org, netem@lists•linux-foundation.org
Subject: Re: [PATCH iproute2] tc/netem: fix loss state display and p14 parsing
Date: Fri, 9 May 2014 12:07:49 -0700 [thread overview]
Message-ID: <20140509120749.0150c757@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <13144.1399600940@localhost.localdomain>
On Thu, 08 May 2014 19:02:20 -0700
Jay Vosburgh <jay.vosburgh@canonical•com> wrote:
>
> The display of the entire netem loss state is shown as if it
> were gemodel state, as the loss state information is assigned to the
> wrong pointer. Correct this by assigning the loss state to the correct
> pointer.
>
> Additionally, attempting to set netem loss state will result in
> random values in the p14 state probability because the option value
> passed to the kernel by tc netem is not parsed or initialized. Fix this
> by supplying a default value of 0 for p14 and parsing the p14 value if
> one is supplied.
>
> Signed-off-by: Jay Vosburgh <jay.vosburgh@canonical•com>
>
> ---
> tc/q_netem.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
Applied
prev parent reply other threads:[~2014-05-09 19:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 2:02 [PATCH iproute2] tc/netem: fix loss state display and p14 parsing Jay Vosburgh
2014-05-09 19:07 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140509120749.0150c757@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber$(echo .)org \
--cc=jay.vosburgh@canonical$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netem@lists$(echo .)linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox