Subject: Re: [PATCH net-next 2/8] bridge: Keep track of ports capable of automatic discovery.

From: Stephen Hemminger <[email-masked]>
Date: Wed, 14 May 2014 08:42:51 -0700

On Wed, 14 May 2014 11:09:22 -0400
Vlad Yasevich <[email-masked]> wrote:

> @@ -58,6 +61,7 @@ static int store_flag(struct net_bridge_port *p, unsigned long v,
>  
>  	if (flags != p->flags) {
>  		p->flags = flags;
> +		br_port_flags_change(p, old_flags ^ flags);

You are also xoring twice.

Why not:

store_flag()
	if (flags != p->flags) {
		br_port_flags_change(p, flags);
		p->flags = flags;
		br_ifinfo_notify(RTM_NEWLINK, p);