From: Stephen Hemminger <stephen@networkplumber•org>
To: Jay Vosburgh <jay.vosburgh@canonical•com>
Cc: netdev@vger•kernel.org, netem@lists•linux-foundation.org
Subject: Re: [PATCH iproute2] tc/netem: loss gemodel options fixes
Date: Thu, 15 May 2014 14:03:34 -0700 [thread overview]
Message-ID: <20140515140334.3724578f@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <29682.1399754098@localhost.localdomain>
On Sat, 10 May 2014 13:34:58 -0700
Jay Vosburgh <jay.vosburgh@canonical•com> wrote:
>
> First, the default value for 1-k is documented as being 0, but is
> currently being set to 1. (100%). This causes all packets to be dropped
> in the good state if 1-k is not explicitly specified. Fix this by setting
> the default to 0.
>
> Second, the 1-h option is parsed correctly, however, the kernel is
> expecting "h", not 1-h. Fix this by inverting the "1-h" percentage before
> sending to and after receiving from the kernel. This does change the
> behavior, but makes it consistent with the netem documentation and the
> literature on the Gilbert-Elliot model, which refer to "1-h" and "1-k,"
> not "h" or "k" directly.
>
> Last, fix a minor formatting issue for the options reporting.
>
> Signed-off-by: Jay Vosburgh <jay.vosburgh@canonical•com>
Could you get review of original author of this loss model?
Stefano Salsano <stefano.salsano@uniroma2•it>
prev parent reply other threads:[~2014-05-15 21:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-10 20:34 [PATCH iproute2] tc/netem: loss gemodel options fixes Jay Vosburgh
[not found] ` <CAPh34mf4ahPyTDf-tEhsNKSFBL6GYjES9+TTvDjhMf2YLTr04Q@mail.gmail.com>
2014-05-15 19:46 ` Jay Vosburgh
2014-08-04 19:37 ` Stephen Hemminger
2014-08-05 8:09 ` Hagen Paul Pfeifer
2014-08-05 18:29 ` Jay Vosburgh
2014-08-05 21:25 ` Hagen Paul Pfeifer
2014-05-15 21:03 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140515140334.3724578f@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber$(echo .)org \
--cc=jay.vosburgh@canonical$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netem@lists$(echo .)linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox