From: Timo Teras <timo.teras@iki•fi>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: Eric Dumazet <edumazet@google•com>,
netdev@vger•kernel.org, Herbert Xu <herbert@gondor•apana.org.au>
Subject: Re: [bisected] [oops] gre/gro oops in skb_gro_receive+0x118/0x453
Date: Fri, 16 May 2014 20:01:12 +0300 [thread overview]
Message-ID: <20140516200112.114cf1bb@vostro> (raw)
In-Reply-To: <1400259027.7973.211.camel@edumazet-glaptop2.roam.corp.google.com>
On Fri, 16 May 2014 09:50:27 -0700
Eric Dumazet <eric.dumazet@gmail•com> wrote:
> On Fri, 2014-05-16 at 19:40 +0300, Timo Teras wrote:
>
> > Both the gre bound interface, and the inside interface are
> > identical.
> >
> > And you are right. It might be driver / hw / gro capability specific
> > issue. I had also report from a user using similar
> > gre/ipsec/forwarding setup, that 3.13-stable kernels works on his
> > hardware.
> >
>
> > Using unmodified in-tree r8169 module.
> >
> > Please let me know if additional information is needed.
>
> What happens if you disable gro on eth0 ?
I believe it crashes, but cannot say with 100% certainty. I can
test later on if needed. Based on earlier experiment, the only way to
avoid the crash was to turn off gro on gre1.
In any case I don't think it should make any effect, since the GRE
packets arrive IPseced. eth0 is receiving ESP packets - and I believe
there's no ESP GRO support. Only after decryption they go to gre1, so
gre1 gro is basically the place where received packets are coalesced.
next prev parent reply other threads:[~2014-05-16 17:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 7:40 [bisected] [oops] gre/gro oops in skb_gro_receive+0x118/0x453 Timo Teras
2014-05-16 12:59 ` Eric Dumazet
2014-05-16 14:34 ` Timo Teras
2014-05-16 16:29 ` Eric Dumazet
2014-05-16 16:40 ` Timo Teras
2014-05-16 16:50 ` Eric Dumazet
2014-05-16 17:01 ` Timo Teras [this message]
2014-05-16 17:13 ` Eric Dumazet
2014-05-16 17:38 ` Timo Teras
2014-05-16 18:04 ` Eric Dumazet
2014-05-16 18:34 ` [PATCH] net: gro: make sure skb->cb[] initial content has not to be zero Eric Dumazet
2014-05-16 19:08 ` Timo Teras
2014-05-16 21:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140516200112.114cf1bb@vostro \
--to=timo.teras@iki$(echo .)fi \
--cc=edumazet@google$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox