From: Thomas Petazzoni <thomas.petazzoni@free-electrons•com>
To: Florian Fainelli <f.fainelli@gmail•com>
Cc: netdev@vger•kernel.org, davem@davemloft•net, devicetree@vger•kernel.org
Subject: Re: [PATCH net-next 2/4] net: systemport: use the new fixed PHY helpers
Date: Mon, 19 May 2014 22:19:46 +0200 [thread overview]
Message-ID: <20140519221946.27dbad55@free-electrons.com> (raw)
In-Reply-To: <1400528625-32744-3-git-send-email-f.fainelli@gmail.com>
Dear Florian Fainelli,
On Mon, 19 May 2014 12:43:43 -0700, Florian Fainelli wrote:
> + priv->phydev = of_phy_connect(dev, priv->phy_dn, bcm_sysport_adj_link,
> + 0, priv->phy_interface);
> if (!priv->phydev) {
> netdev_err(dev, "could not attach to PHY\n");
> return -ENODEV;
> @@ -1551,6 +1551,20 @@ static int bcm_sysport_probe(struct platform_device *pdev)
> if (priv->phy_interface < 0)
> priv->phy_interface = PHY_INTERFACE_MODE_GMII;
>
> + /* SYSTEMPORT uses the old 'fixed-link' 5-digit property which is
> + * deprecated, we need to register the fixed PHY using the Ethernet
> + * MAC node since we do not have a 'fixed-link' subnode.
> + */
Actually even if you use the new fixed PHY DT binding, the DT node
linked to the PHY is the Ethernet MAC node. This is because I didn't
want to have a difference between how things are handled between the
old and the new binding.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-05-19 20:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 19:43 [PATCH net-next 0/4] broadcom drivers and fixed-link doc updates Florian Fainelli
2014-05-19 19:43 ` [PATCH net-next 1/4] net: bcmgenet: use the new fixed PHY helpers Florian Fainelli
2014-05-19 21:22 ` Sergei Shtylyov
2014-05-19 19:43 ` [PATCH net-next 2/4] net: systemport: " Florian Fainelli
2014-05-19 20:19 ` Thomas Petazzoni [this message]
[not found] ` <20140519221946.27dbad55-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-05-19 21:52 ` Florian Fainelli
2014-05-19 22:04 ` Thomas Petazzoni
[not found] ` <20140520000420.7039e1bc-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-05-19 23:31 ` Florian Fainelli
2014-05-19 19:43 ` [PATCH net-next 3/4] Documentation: devicetree: add old and deprecated 'fixed-link' Florian Fainelli
2014-05-19 20:22 ` Thomas Petazzoni
2014-05-19 19:43 ` [PATCH net-next 4/4] Documentation: devicetree: net: refer to fixed-link.txt Florian Fainelli
2014-05-19 20:23 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140519221946.27dbad55@free-electrons.com \
--to=thomas.petazzoni@free-electrons$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=f.fainelli@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox