Subject: Re: [PATCH net-next] bridge: fix the unbalanced promiscuous count when add_if failed

From: Stephen Hemminger <[email-masked]>
Date: Fri, 30 May 2014 07:34:46 -0700

On Thu, 29 May 2014 10:15:30 +0800
Wang Weidong <[email-masked]> wrote:

> As commit 2796d0c648c94("bridge: Automatically manage port
> promiscuous mode."), make the add_if use dev_set_allmulti
> instead of dev_set_promiscuous, so when add_if failed, we
> should do dev_set_allmulti(dev, -1).
> 
> Signed-off-by: Wang Weidong <[email-masked]>

Good catch.
Acked-by: Stephen Hemminger <[email-masked]>