Subject: Re: [PATCH] netfilter: nf_conntrack: fix checkpatch errors

From: Patrick McHardy <[email-masked]>
Date: Tue, 3 Jun 2014 21:48:43 +0100

On Tue, Jun 03, 2014 at 04:45:02PM +0200, Luca Ellero wrote:
> Add parenthesis around complex macros
> 
> Signed-off-by: Luca Ellero <[email-masked]>
> ---
>  net/netfilter/nf_conntrack_pptp.c       |    6 +++---
>  net/netfilter/nf_conntrack_proto_sctp.c |    8 ++++----
>  net/netfilter/nf_conntrack_proto_tcp.c  |    8 ++++----
>  3 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/net/netfilter/nf_conntrack_pptp.c b/net/netfilter/nf_conntrack_pptp.c
> index 825c3e3..a505263 100644
> --- a/net/netfilter/nf_conntrack_pptp.c
> +++ b/net/netfilter/nf_conntrack_pptp.c
> @@ -92,9 +92,9 @@ const char *const pptp_msg_name[] = {
>  EXPORT_SYMBOL(pptp_msg_name);
>  #endif
>  
> -#define SECS *HZ
> -#define MINS * 60 SECS
> -#define HOURS * 60 MINS
> +#define SECS  (*HZ)
> +#define MINS  (*60 SECS)
> +#define HOURS (*60 MINS)

Don't send patches that you obviously didn't even compile test.