From: Greg KH <gregkh@linuxfoundation•org>
To: David Miller <davem@davemloft•net>
Cc: daniel.kiper@oracle•com, stable@vger•kernel.org, msw@amazon•com,
netdev@vger•kernel.org, xen-devel@lists•xen.org,
konrad.wilk@oracle•com
Subject: Re: [PATCH 3.4] xen-netback: allow changing the MAC address of the interface
Date: Thu, 5 Jun 2014 16:14:58 -0700 [thread overview]
Message-ID: <20140605231458.GA31114@kroah.com> (raw)
In-Reply-To: <20140605.145844.382754247234672637.davem@davemloft.net>
On Thu, Jun 05, 2014 at 02:58:44PM -0700, David Miller wrote:
> From: Daniel Kiper <daniel.kiper@oracle•com>
> Date: Mon, 2 Jun 2014 21:46:20 +0200
>
> > From: Matt Wilson <msw@amazon•com>
> >
> > Sometimes it is useful to be able to change the MAC address of the
> > interface for netback devices. For example, when using ebtables it may
> > be useful to be able to distinguish traffic from different interfaces
> > without depending on the interface name.
> >
> > Reported-by: Nikita Borzykh <sample.n@gmail•com>
> > Reported-by: Paul Harvey <stockingpaul@hotmail•com>
> > Cc: netdev@vger•kernel.org
> > Cc: xen-devel@lists•xen.org
> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle•com>
> > Acked-by: Ian Campbell <ian.campbell@citrix•com>
> > Signed-off-by: Matt Wilson <msw@amazon•com>
> > Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle•com>
> > Signed-off-by: David S. Miller <davem@davemloft•net>
> > (cherry picked from commit 4a633a602c26497b8285a202830829d3be007c7b)
> >
> > Signed-off-by: Daniel Kiper <daniel.kiper@oracle•com>
> > Tested-by: Daniel Kiper <daniel.kiper@oracle•com>
> > Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle•com>
>
> I don't think this is suitable for -stable.
>
> -stable should be restricted bug fixes for things that either
> are extremely serious, or hit a very huge segment of the user
> base.
>
> This issue does not quality for either condition.
Yeah, it seems like a new feature to me, I'll drop it from my to-apply
queue.
thanks for the review,
greg k-h
next prev parent reply other threads:[~2014-06-05 23:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 19:46 [PATCH 3.4] xen-netback: allow changing the MAC address of the interface Daniel Kiper
2014-06-05 21:58 ` David Miller
2014-06-05 23:14 ` Greg KH [this message]
2014-06-06 13:04 ` Daniel Kiper
2014-06-06 13:56 ` Greg KH
2014-06-06 20:02 ` Daniel Kiper
2014-06-06 20:12 ` [Xen-devel] " Andrew Cooper
2014-06-06 20:31 ` Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140605231458.GA31114@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=daniel.kiper@oracle$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=konrad.wilk@oracle$(echo .)com \
--cc=msw@amazon$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stable@vger$(echo .)kernel.org \
--cc=xen-devel@lists$(echo .)xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox