Subject: Re: [PATCH] list: Fix order of arguments for hlist_add_after(_rcu)

From: Greg KH <[email-masked]>
Date: Fri, 6 Jun 2014 08:50:12 -0700

On Fri, Jun 06, 2014 at 11:42:23AM +0200, Ken Helias wrote:
> All other add functions for lists have the new item as first argument and the
> position where it is added as second argument. This was changed for no good
> reason in this function and makes using it unnecessary confusing.
> 
> Also the naming of the arguments in hlist_add_after was confusing. It was
> changed to use the same names as hlist_add_after_rcu.
> 
> Signed-off-by: Ken Helias <[email-masked]>
> Cc: David Airlie <[email-masked]>
> Cc: Jeff Kirsher <[email-masked]>
> Cc: Jesse Brandeburg <[email-masked]>
> Cc: Bruce Allan <[email-masked]>
> Cc: Carolyn Wyborny <[email-masked]>
> Cc: Don Skidmore <[email-masked]>
> Cc: Greg Rose <[email-masked]>
> Cc: Alex Duyck <[email-masked]>
> Cc: John Ronciak <[email-masked]>
> Cc: Mitch Williams <[email-masked]>
> Cc: Linux NICS <[email-masked]>
> Cc: Alexander Viro <[email-masked]>
> Cc: Dipankar Sarma <[email-masked]>
> Cc: "Paul E. McKenney" <[email-masked]>
> Cc: Marek Lindner <[email-masked]>
> Cc: Simon Wunderlich <[email-masked]>
> Cc: Antonio Quartulli <[email-masked]>
> Cc: "David S. Miller" <[email-masked]>
> Cc: Stephen Hemminger <[email-masked]>
> Cc: Alexey Kuznetsov <[email-masked]>
> Cc: James Morris <[email-masked]>
> Cc: Hideaki YOSHIFUJI <[email-masked]>
> Cc: Patrick McHardy <[email-masked]>
> Cc: Steffen Klassert <[email-masked]>
> Cc: Herbert Xu <[email-masked]>
> Cc: [email-masked]
> Cc: [email-masked]
> Cc: [email-masked]
> Cc: [email-masked]
> Cc: [email-masked]
> Cc: [email-masked]
> Cc: [email-masked]
> ---
> Patch based on "Add linux-next specific files for 20140606"
> 
>  drivers/gpu/drm/drm_hashtab.c                    |  2 +-
>  drivers/net/ethernet/intel/i40e/i40e_ethtool.c   |  2 +-
>  drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c |  2 +-
>  drivers/staging/lustre/lustre/libcfs/hash.c      |  4 ++--
>  fs/namespace.c                                   |  2 +-
>  fs/notify/inode_mark.c                           |  2 +-
>  fs/notify/vfsmount_mark.c                        |  2 +-
>  include/linux/list.h                             | 12 ++++++------
>  include/linux/rculist.h                          |  6 +++---
>  net/batman-adv/fragmentation.c                   |  2 +-
>  net/bridge/br_multicast.c                        |  2 +-
>  net/ipv4/fib_trie.c                              |  2 +-
>  net/ipv6/addrlabel.c                             |  2 +-
>  net/xfrm/xfrm_policy.c                           |  4 ++--
>  14 files changed, 23 insertions(+), 23 deletions(-)

drivers/staging/ portion:
	Acked-by: Greg Kroah-Hartman <[email-masked]>